From: "Torsten Bögershausen" <tboegi@web.de>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Jon Forrest <nobozo@gmail.com>,
git@vger.kernel.org
Subject: Re: Odd Difference Between Windows Git and Standard Git
Date: Wed, 25 May 2016 06:36:09 +0200 [thread overview]
Message-ID: <57452BB9.5090500@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1605241352361.4449@virtualbox>
On 05/24/2016 01:57 PM, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 24 May 2016, Torsten Bögershausen wrote:
>
>> On 05/23/2016 08:52 PM, Junio C Hamano wrote:
>>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>>
>>>>> Of course, if you are doing network mount between systems with and
>>>>> without filemode support, the result would depend on where you did
>>>>> the "git init", so that would not help.
>>>>>
>>>>> Which means that other probed things like symlink support and case
>>>>> sensitivity are likely to be wrong in the .git/config that the
>>>>> user may want to fix.
>>>> What we could do is to make the default config setting
>>>> platform-dependent, a la CRLF_NATIVE.
>>>>
>>>> I imagine that we would want this for core.filemode, core.ignorecase and
>>>> core.symlinks.
>>>>
>>>> What do you think?
>>> The reason why we probe for filemode, icase, etc. at repository
>>> creation time and record the result in the configuration is because we
>>> do not to want to do the auto-probing at runtime, every time we run
>>> any Git command.
> Right, I missed this of course. My idea was to have saner defaults *iff
> the config variables are not set explicitly*. But they *are* set, of
> course. Just not in a way that makes sense when the very same working
> directory is accessed from different Operating Systems.
>
>> if core.filemode is true, Git for Windows could:
>> a) Behave as today, report changed files (filemode)
>> b) Give warning to the user (and report changed filemode)
>> c) Error out, saying misconfigured worktree
>> d) use core.filemode = false anyway.
>> e) Give a warning and use core.filemode = false anyway.
>>
>> At the moment I tend for c), as it makes it clear what is going wrong,
>> what do you think ?
> The problem with that is that we would need to probe again.
The probing for the filemode:
Wouldn't it be enough to run lstat() on .git/ ?
If the user-execuatable bit is not set, but core.filemode is true, error
out ?
That would not cost too much.
> Or dictate for
> all eternity that Git for Windows cannot determine the executable bit (but
> who knows for certain?)
Can we can limit the eternity until the day when Windows can determine
the executable
bit ?
next prev parent reply other threads:[~2016-05-25 4:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 1:48 Odd Difference Between Windows Git and Standard Git Jon Forrest
2016-05-20 13:19 ` Torsten Bögershausen
2016-05-20 13:48 ` Jon Forrest
2016-05-20 14:19 ` Torsten Bögershausen
2016-05-20 14:28 ` Jon Forrest
2016-05-20 15:57 ` Torsten Bögershausen
2016-05-20 15:23 ` Junio C Hamano
2016-05-20 16:12 ` Torsten Bögershausen
2016-05-20 16:21 ` Junio C Hamano
2016-05-23 11:12 ` Johannes Schindelin
2016-05-23 13:44 ` Jon Forrest
2016-05-23 15:08 ` Johannes Schindelin
2016-05-23 18:52 ` Junio C Hamano
2016-05-24 4:52 ` Torsten Bögershausen
2016-05-24 11:57 ` Johannes Schindelin
2016-05-25 4:36 ` Torsten Bögershausen [this message]
2016-05-25 11:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57452BB9.5090500@web.de \
--to=tboegi@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nobozo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).