From: "René Scharfe" <l.s.r@web.de>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] xemit.c: fix a [-Wchar-subscripts] compiler warning
Date: Thu, 26 May 2016 04:22:04 +0200 [thread overview]
Message-ID: <57465DCC.9080809@web.de> (raw)
In-Reply-To: <57462FF3.4010705@ramsayjones.plus.com>
[sorry for duplicate]
Am 26.05.2016 um 01:06 schrieb Ramsay Jones:
>
> While compiling on cygwin (x86_64), gcc complains thus:
>
> CC xdiff/xemit.o
> xdiff/xemit.c: In function ‘is_empty_rec’:
> xdiff/xemit.c:163:2: warning: array subscript has type ‘char’ [-Wchar-subscripts]
> while (len > 0 && isspace(*rec)) {
> ^
Ah, it's not using our own isspace(), which works fine with signed
chars, because it doesn't include git-compat-util.h. I'm spoilt by
those char classifier macros that can be actually used with chars..
Thanks for catching!
René
prev parent reply other threads:[~2016-05-26 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 23:06 [PATCH] xemit.c: fix a [-Wchar-subscripts] compiler warning Ramsay Jones
2016-05-26 2:22 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57465DCC.9080809@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).