From: Michael Haggerty <mhagger@alum.mit.edu>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>,
David Turner <dturner@twopensource.com>
Cc: "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 09/13] refs: introduce an iterator interface
Date: Tue, 31 May 2016 03:16:49 +0200 [thread overview]
Message-ID: <574CE601.3010701@alum.mit.edu> (raw)
In-Reply-To: <574C70EF.5070705@ramsayjones.plus.com>
On 05/30/2016 06:57 PM, Ramsay Jones wrote:
>
>
> On 30/05/16 16:22, Ramsay Jones wrote:
>>
>>
>> On 30/05/16 08:55, Michael Haggerty wrote:
>> [snip]
>>
>>> /* Reference is a symbolic reference. */
>>> diff --git a/refs/files-backend.c b/refs/files-backend.c
>>> index 8ab4d5f..dbf1587 100644
>>> --- a/refs/files-backend.c
>>> +++ b/refs/files-backend.c
>>> [...]
>>> + sort_ref_dir(dir);
>>
>> do you need to sort here ...
>>> [...]
>>> + sort_ref_dir(level->dir);
>>
>> ... given that you sort here?
>
> I had intended to say 'or vice versa' here. When I wrote this, I had not
> finished reading this patch (let alone the series). Now, I suspect that
> you can simply drop this 'sort_ref_dir()' call site. Unless I've misread
> the code, of course! ;-)
Yes, you are right. Thanks for catching this! I'll fix it in v2.
Michael
next prev parent reply other threads:[~2016-05-31 1:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 7:55 [PATCH 00/13] Reference iterators Michael Haggerty
2016-05-30 7:55 ` [PATCH 01/13] refs: remove unnecessary "extern" keywords Michael Haggerty
2016-05-30 7:55 ` [PATCH 02/13] do_for_each_ref(): move docstring to the header file Michael Haggerty
2016-05-30 7:55 ` [PATCH 03/13] refs: use name "prefix" consistently Michael Haggerty
2016-05-30 7:55 ` [PATCH 04/13] delete_refs(): add a flags argument Michael Haggerty
2016-05-30 7:55 ` [PATCH 05/13] remote rm: handle symbolic refs correctly Michael Haggerty
2016-05-30 7:55 ` [PATCH 06/13] get_ref_cache(): only create an instance if there is a submodule Michael Haggerty
2016-05-30 7:55 ` [PATCH 07/13] entry_resolves_to_object(): rename function from ref_resolves_to_object() Michael Haggerty
2016-05-30 7:55 ` [PATCH 08/13] ref_resolves_to_object(): new function Michael Haggerty
2016-05-30 7:55 ` [PATCH 09/13] refs: introduce an iterator interface Michael Haggerty
2016-05-30 15:22 ` Ramsay Jones
2016-05-30 16:57 ` Ramsay Jones
2016-05-31 1:16 ` Michael Haggerty [this message]
2016-05-31 5:29 ` Eric Sunshine
2016-05-31 7:59 ` Michael Haggerty
2016-05-31 23:12 ` Eric Sunshine
2016-06-03 11:48 ` Michael Haggerty
2016-05-31 6:10 ` Junio C Hamano
2016-05-31 8:45 ` Michael Haggerty
2016-06-02 10:08 ` Duy Nguyen
2016-06-02 16:23 ` Michael Haggerty
2016-05-30 7:55 ` [PATCH 10/13] do_for_each_ref(): reimplement using reference iteration Michael Haggerty
2016-05-30 7:55 ` [PATCH 11/13] for_each_reflog(): don't abort for bad references Michael Haggerty
2016-05-30 7:55 ` [PATCH 12/13] dir_iterator: new API for iterating over a directory tree Michael Haggerty
2016-06-01 0:12 ` David Turner
2016-06-03 11:57 ` Michael Haggerty
2016-05-30 7:55 ` [PATCH 13/13] for_each_reflog(): reimplement using iterators Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574CE601.3010701@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).