git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	Junio C Hamano <gitster@pobox.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t4014: shell portability fix
Date: Wed, 1 Jun 2016 07:48:12 +0200	[thread overview]
Message-ID: <574E771C.7030009@kdbg.org> (raw)
In-Reply-To: <20160601033139.GB5411@sigill.intra.peff.net>

Am 01.06.2016 um 05:31 schrieb Jeff King:
> 	printf '%s' "$1" | sed "s/'/'\\\\''/g"
...
> 	export -p | grep "^declare -x $1="
...
> 					"$fake_env_var_=$(shellquote "$fake_env_orig_")"
...
> 			eval "$fake_env_var_=$(shellquote "$fake_env_val_")"

An intolerable number of new processes... Please stop this mental exercise.

-- Hannes

  parent reply	other threads:[~2016-06-01  5:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 22:53 [PATCH] t4014: shell portability fix Junio C Hamano
2016-05-31 22:56 ` Jeff King
2016-06-01  0:09   ` Eric Sunshine
2016-06-01  2:31     ` Jeff King
2016-06-01  3:31       ` Jeff King
2016-06-01  3:44         ` Jeff King
2016-06-01  3:54           ` Jeff King
2016-06-01  5:33           ` Jeff King
2016-06-01  5:40             ` Jeff King
2016-06-01  6:49               ` Junio C Hamano
2016-06-01  6:57                 ` Junio C Hamano
2016-06-01  7:04                 ` Jeff King
2016-06-01 15:07                   ` Junio C Hamano
2016-06-01 16:07                     ` Jeff King
2016-06-01 16:57                       ` Junio C Hamano
2016-06-01 16:58                         ` Jeff King
2016-06-01  5:48         ` Johannes Sixt [this message]
2016-06-01  5:48           ` Jeff King
2016-06-01  6:39       ` Eric Sunshine
2016-06-01  0:09 ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574E771C.7030009@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).