From: "Jonathan del Strother" <maillist@steelskies.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: git@vger.kernel.org
Subject: Re: Serious bug with pretty format strings & empty bodies?
Date: Thu, 20 Dec 2007 10:43:40 +0000 [thread overview]
Message-ID: <57518fd10712200243o26641b3bjf9be3898a2f0c7e1@mail.gmail.com> (raw)
In-Reply-To: <476962D5.3050409@lsrfire.ath.cx>
On Dec 19, 2007 6:28 PM, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
> That's strange. Could you check if this happens with e52a5de, too?
> That's the commit that introduced --pretty=format. If it doesn't, could
> you then please try to bisect the bug?
As far as I can tell, e52a... never compiled - it's missing prefixcmp
from git-compat-util.h, which doesn't get merged in till 8ab3e18.
And yes, I still get junk output from that build. (Shame, I was
looking forward to trying out the bisect tool...)
> How many '<unknown>' markers are there in the output of version 1.5.3.7
> (and e52a5de)? One per %b? Are they the only output or are they
> combined with parts of unrelated commits, too?
Only one per %b, and where they appear, they're the only output.
However, even with those builds, I get junk output in addition to the
<unknown> markers.
That is, with a format string of "**%b**", there are three possible outputs :
The correct one - eg **Added test for NSDictionary generator**
The unknown one - eg **<unknown>**
The complete junk one - eg **n del
Strothereb0d794bacc1761e8a0681e9b144c514702d9b7a**
The latter's 'body' is almost always terminated by an unprintable
character, which always seems to be 03.
Hmmm. I wonder if it's coincidence that I can only seem to spot this
problem in my repos that have been set up via submodule init...
next prev parent reply other threads:[~2007-12-20 10:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 14:32 Serious bug with pretty format strings & empty bodies? Jonathan del Strother
2007-12-19 18:28 ` René Scharfe
2007-12-20 10:43 ` Jonathan del Strother [this message]
2007-12-20 10:46 ` Jonathan del Strother
2007-12-19 18:44 ` Alex Riesen
2007-12-19 22:37 ` Jonathan del Strother
2007-12-19 23:23 ` René Scharfe
2007-12-20 10:44 ` Jonathan del Strother
2007-12-20 12:20 ` René Scharfe
2007-12-20 12:37 ` Johannes Schindelin
2007-12-20 13:08 ` Jonathan del Strother
2007-12-21 10:47 ` Jonathan del Strother
2007-12-22 8:39 ` Junio C Hamano
2007-12-22 15:48 ` Jonathan del Strother
2007-12-20 11:38 ` Jonathan del Strother
2007-12-20 12:34 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57518fd10712200243o26641b3bjf9be3898a2f0c7e1@mail.gmail.com \
--to=maillist@steelskies.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).