From: "Jonathan del Strother" <maillist@steelskies.com>
To: "Andreas Ericsson" <ae@op5.se>
Cc: git@vger.kernel.org, vmiklos@frugalware.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Teach git diff about Objective-C syntax
Date: Wed, 17 Sep 2008 16:31:17 +0100 [thread overview]
Message-ID: <57518fd10809170831x6d84aeb0m9b0b2c4095a1de70@mail.gmail.com> (raw)
In-Reply-To: <48D11C3C.5070707@op5.se>
On Wed, Sep 17, 2008 at 4:03 PM, Andreas Ericsson <ae@op5.se> wrote:
> Jonathan del Strother wrote:
>> { "pascal", "^\\(\\(procedure\\|function\\|constructor\\|"
>> "destructor\\|interface\\|implementation\\|"
>> "initialization\\|finalization\\)[ \t]*.*\\)$"
>> "\\|"
>> - "^\\(.*=[ \t]*\\(class\\|record\\).*\\)$"
>> - },
>> + "^\\(.*=[ \t]*\\(class\\|record\\).*\\)$"},
>> +
>
> This last change is just pure nonsense. Please remove it altogether.
>
I was changing it to match the style in the existing java pattern (and
my objc pattern). You think the java one should be changed to match
the pascal one, then?
next prev parent reply other threads:[~2008-09-17 15:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 23:21 [PATCH] Teach git diff about Objective-C syntax Jonathan del Strother
2008-09-16 23:39 ` Miklos Vajna
2008-09-17 0:07 ` Jonathan del Strother
2008-09-17 10:49 ` Jonathan del Strother
2008-09-17 11:06 ` Johannes Schindelin
2008-09-17 12:26 ` Jonathan del Strother
2008-09-17 13:29 ` Jonathan del Strother
2008-09-17 15:03 ` Andreas Ericsson
2008-09-17 15:31 ` Jonathan del Strother [this message]
2008-09-17 15:55 ` Miklos Vajna
2008-09-17 19:14 ` Jonathan del Strother
2008-09-17 20:44 ` Junio C Hamano
2008-09-17 23:30 ` Jonathan del Strother
2008-09-30 23:46 ` [PATCH v2] " Jonathan del Strother
2008-10-01 0:52 ` Brandon Casey
2008-10-01 19:28 ` [PATCH] xdiff-interface.c: strip newline (and cr) from line before pattern matching Brandon Casey
2008-10-01 20:05 ` Johannes Schindelin
2008-10-02 10:29 ` Jonathan del Strother
2008-10-02 10:40 ` [PATCH v2] Teach git diff about Objective-C syntax Jonathan del Strother
2008-09-18 6:50 ` [PATCH] " Andreas Ericsson
2008-09-17 13:37 ` Jonathan del Strother
2008-09-17 14:28 ` Johannes Schindelin
2008-09-17 14:32 ` Jonathan del Strother
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57518fd10809170831x6d84aeb0m9b0b2c4095a1de70@mail.gmail.com \
--to=maillist@steelskies.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).