From: "Jonathan del Strother" <maillist@steelskies.com>
To: "Brandon Casey" <casey@nrlssc.navy.mil>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Arjen Laarhoven" <arjen@yaph.org>,
"Mike Ralphson" <mike.ralphson@gmail.com>,
"Johannes Sixt" <j.sixt@viscovery.net>,
"Jeff King" <peff@peff.net>,
"Boyd Lynn Gerber" <gerberb@zenez.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Avery Pennarun" <apenwarr@gmail.com>,
"Johan Herland" <johan@herland.net>,
"Andreas Ericsson" <ae@op5.se>,
"Kirill Smelkov" <kirr@mns.spb.ru>,
"Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
Subject: Re: [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions
Date: Thu, 18 Sep 2008 11:53:48 +0100 [thread overview]
Message-ID: <57518fd10809180353q2564d873k98e5f6d9041d0a7@mail.gmail.com> (raw)
In-Reply-To: <-f-gqL4SkA8Uh7hSuKT-JDY0g26jHn3fDQCE24MB1nKWUMLZWuSseg@cipher.nrlssc.navy.mil>
On Thu, Sep 18, 2008 at 1:21 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>
>
> This is a blind conversion removing \\ before ( and { etc.
> and adding \\ before naked ( and { etc.
>
> I hope the authors who last touched these patterns will help with testing:
None of the patterns using \\s seem to work for me. I had to replace
them with [ \t] - is this a problem with the darwin regex
compatibility library or something? I applied the patches on master
(97d7fee2cb), and am running OS X 10.5.5.
next prev parent reply other threads:[~2008-09-18 10:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 18:45 [RFC/PATCH] Use compatibility regex library for OSX/Darwin Arjen Laarhoven
2008-09-10 8:03 ` Mike Ralphson
2008-09-10 9:49 ` Johannes Sixt
2008-09-10 10:03 ` Arjen Laarhoven
2008-09-10 11:53 ` Mike Ralphson
2008-09-11 7:59 ` Mike Ralphson
2008-09-11 8:14 ` [PATCH] Use compatibility regex library also on AIX Johannes Sixt
2008-09-11 8:25 ` Arjen Laarhoven
2008-09-11 8:31 ` Mike Ralphson
2008-09-11 12:12 ` Jeff King
2008-09-11 8:27 ` Junio C Hamano
2008-09-16 17:49 ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Brandon Casey
2008-09-16 18:09 ` Junio C Hamano
2008-09-18 0:08 ` [PATCH 1/4] diff.c: return pattern entry pointer rather than just the hunk header pattern Brandon Casey
2008-09-18 0:10 ` [PATCH 2/4] diff.c: associate a flag with each pattern and use it for compiling regex Brandon Casey
2008-09-18 4:14 ` Junio C Hamano
2008-09-18 6:41 ` Andreas Ericsson
2008-09-18 7:12 ` Junio C Hamano
2008-09-18 8:06 ` Andreas Ericsson
2008-09-18 8:35 ` Junio C Hamano
2008-09-18 0:10 ` [PATCH 3/4] diff.*.xfuncname which uses "extended" regex's for hunk header selection Brandon Casey
[not found] ` <7vd4j212gb.fsf@gitster.siamese.dyndns.org>
2008-09-19 18:14 ` Brandon Casey
2008-09-18 0:21 ` [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions Brandon Casey
2008-09-18 0:33 ` [PATCH 4/4 v2] " Brandon Casey
2008-09-18 7:18 ` [PATCH 4/4] " Andreas Ericsson
2008-09-18 7:31 ` Junio C Hamano
2008-09-18 8:39 ` Johan Herland
2008-09-18 10:15 ` Gustaf Hendeby
2008-09-18 10:53 ` Jonathan del Strother [this message]
2008-09-18 15:48 ` Brandon Casey
2008-09-16 19:08 ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Jeff King
2008-09-16 23:25 ` Boyd Lynn Gerber
2008-09-16 23:32 ` Jeff King
2008-09-16 23:42 ` Boyd Lynn Gerber
2008-09-16 23:46 ` Jeff King
2008-09-17 0:10 ` Boyd Lynn Gerber
2008-09-17 0:13 ` Brandon Casey
2008-09-17 0:13 ` Boyd Lynn Gerber
2008-09-17 0:20 ` Brandon Casey
2008-09-17 0:38 ` Boyd Lynn Gerber
2008-09-17 0:58 ` Brandon Casey
2008-09-17 1:02 ` Boyd Lynn Gerber
2008-09-17 1:25 ` Brandon Casey
2008-09-17 14:48 ` Boyd Lynn Gerber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57518fd10809180353q2564d873k98e5f6d9041d0a7@mail.gmail.com \
--to=maillist@steelskies.com \
--cc=ae@op5.se \
--cc=apenwarr@gmail.com \
--cc=arjen@yaph.org \
--cc=casey@nrlssc.navy.mil \
--cc=gerberb@zenez.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=j.sixt@viscovery.net \
--cc=johan@herland.net \
--cc=kirr@mns.spb.ru \
--cc=mike.ralphson@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).