git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan del Strother <maillist@steelskies.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-submodule should obey --quiet for subcommands
Date: Thu, 24 Sep 2009 08:34:13 +0100	[thread overview]
Message-ID: <57518fd10909240034p668f858bh17fc20715b4838c3@mail.gmail.com> (raw)
In-Reply-To: <20090924143130.6117@nanako3.lavabit.com>

On Thu, Sep 24, 2009 at 6:31 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Quoting Jonathan del Strother <maillist@steelskies.com>
>
>> No takers?  Perhaps I should explain my interest in this patch : we
>> use Capistrano to deploy our Rails app which contains a bunch of
>> submodules.  It's done over ssh, so the 'git submodule update' step
>> during deployment spews something along the lines of :
>>
>> Receiving objects: 0% (0/401), 1.55 MiB | 424 KiB/s
>> Receiving objects: 1% (4/401), 2.15 MiB | 612 KiB/s
>> Receiving objects: 2% (8/401), 2.90 MiB | 510 KiB/s
>> ....
>> ..
>
> Does 'git clone' itself do that to you, too, or do you see these output on separate lines only when running 'git submodule clone'? I never used 'git submodule clone' but with 'git clone' these lines seem to overwrite one after another and they never bothered me. Could your terminal emulator be broken?
>

No, git clone has the same problem when run under Capistrano, but it
obeys --quiet.

That said, I always assumed that, say, 'ssh -t myhost git clone foo'
would have the same problem (ie printing each progress update on a new
line), but I see it works correctly.  Looks like Capistrano is eating
the \r somewhere.  I still think my patch is valid, but I'll
investigate into Capistrano some more & see if I can fix it there.

Jonathan

  reply	other threads:[~2009-09-24  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21 16:46 [PATCH] git-submodule should obey --quiet for subcommands Jonathan del Strother
2009-09-23 21:33 ` Jonathan del Strother
2009-09-24  5:31   ` Nanako Shiraishi
2009-09-24  7:34     ` Jonathan del Strother [this message]
2009-09-24  9:15       ` Jonathan del Strother

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57518fd10909240034p668f858bh17fc20715b4838c3@mail.gmail.com \
    --to=maillist@steelskies.com \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).