From: Jonathan del Strother <maillist@steelskies.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Fix memory corruption when .gitignore does not end by \n
Date: Thu, 21 Jan 2010 06:08:37 +0000 [thread overview]
Message-ID: <57518fd11001202208x3dfd68f6p793f77cb85534923@mail.gmail.com> (raw)
In-Reply-To: <fcaeb9bf1001201738x5cd374c2o280ec42d6d65c0f7@mail.gmail.com>
2010/1/21 Nguyen Thai Ngoc Duy <pclouds@gmail.com>:
> On 1/21/10, Junio C Hamano <gitster@pobox.com> wrote:
>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>>
>> > This patch causes a crash for me. Not sure if it does for anybody else.
>>
>>
>> I am puzzled. What do you mean by this? If this patch makes the code
>> crash, then it is not a fix. Is this meant as "Jonathan, can you try this
>> patch and tell me what happens, so that I can diagnose the issue better?"
>> patch?
>
> I mean the t3001 patch in comment part, which removes \n at the end of
> .gitignore and crashes the unmodified git.
>
> IOW I found a problem and this patch (not the t3001 one) should fix
> it. Not sure if this causes Jonathan problem though.
>
>> Is it better/safer to revert the entire nd/sparse topic from the master in
>> the meantime before we know what is going on?
>
> I would wait for Jonathan response. If this is not the cause, probably
> safer to revert it.
> --
> Duy
>
Think it's all fixed after applying this patch - at least, I can no
longer reproduce the crash, whereas I was able to make it fail ~90% of
the time before.
next prev parent reply other threads:[~2010-01-21 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 17:59 git-status segmentation fault in master / OS X Jonathan del Strother
2010-01-20 0:41 ` Jeff King
2010-01-20 0:56 ` Junio C Hamano
2010-01-20 10:43 ` Jonathan del Strother
2010-01-20 12:58 ` Nguyen Thai Ngoc Duy
2010-01-20 14:09 ` [PATCH] Fix memory corruption when .gitignore does not end by \n Nguyễn Thái Ngọc Duy
2010-01-20 19:51 ` Junio C Hamano
2010-01-21 1:38 ` Nguyen Thai Ngoc Duy
2010-01-21 6:08 ` Jonathan del Strother [this message]
2010-01-21 6:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57518fd11001202208x3dfd68f6p793f77cb85534923@mail.gmail.com \
--to=maillist@steelskies.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).