git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Compilation errors in git.pu/refs/reftable-backend.c
Date: Mon, 27 Apr 2020 06:34:43 +0200	[thread overview]
Message-ID: <575af27b-3823-2db5-ad3b-3c6cd7a95faa@web.de> (raw)

Folks, after the integration of the reftable branch:
Merge branch 'hn/reftable' into pu

My historic (?) compiler stumbles over this code here:
refs/reftable-backend.c
   for (int i = 0; i < transaction->nr; i++) {

So I think we could easily avoid the (for int i) construction.
The other observation could be, why we use an "int", when "nr" is
defined as a size_t ?

struct ref_transaction {
	struct ref_store *ref_store;
	struct ref_update **updates;
	size_t alloc;
	size_t nr;
	enum ref_transaction_state state;
	void *backend_data;
};

Thanks for working on Git

             reply	other threads:[~2020-04-27  4:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  4:34 Torsten Bögershausen [this message]
2020-04-27 12:05 ` Compilation errors in git.pu/refs/reftable-backend.c Han-Wen Nienhuys
2020-04-27 12:13   ` Jeff King
2020-04-27 13:13   ` Carlo Marcelo Arenas Belón
2020-04-27 23:26     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575af27b-3823-2db5-ad3b-3c6cd7a95faa@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=hanwen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).