git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jakub Narębski" <jnareb@gmail.com>
To: Alex Riesen <alexander.riesen@cetitec.com>, git@vger.kernel.org
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files
Date: Mon, 27 Jun 2016 19:32:25 +0200	[thread overview]
Message-ID: <57716329.8000809@gmail.com> (raw)
In-Reply-To: <20160627132308.GD4194@pflmari>

W dniu 2016-06-27 o 15:23, Alex Riesen pisze:
> It is very confusing that the file, diff of which is displayed and which is
> marked as selected in the file list, is not, in fact, selected. I.e. the array
> of selected files does not contain an entry for it.
> 
> Fixing this also improves the use of $FILENAMES in custom defined tools: one
> does not have to click the file in the list to make it selected.

Could you improve the readability of the commit message, please? Perhaps
something like the following:

  It is very confusing that the file which diff is displayed is marked as
  selected, but it is not in fact selected (that means the array of selected
  files does not include the file in question).

  ...

This patch lacks sign-off.

> ---
>  lib/diff.tcl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/diff.tcl b/lib/diff.tcl
> index 0d56986..30bdd69 100644
> --- a/lib/diff.tcl
> +++ b/lib/diff.tcl
> @@ -127,6 +127,9 @@ proc show_diff {path w {lno {}} {scroll_pos {}} {callback {}}} {
>  	} else {
>  		start_show_diff $cont_info
>  	}
> +
> +	global current_diff_path selected_paths
> +	set selected_paths($current_diff_path) 1
>  }
>  
>  proc show_unmerged_diff {cont_info} {
> 


  reply	other threads:[~2016-06-27 17:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 13:21 [PATCH 1/2] Support for $FILENAMES in tool definitions Alex Riesen
2016-06-27 13:23 ` [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files Alex Riesen
2016-06-27 17:32   ` Jakub Narębski [this message]
2016-06-28  8:03     ` Alex Riesen
2016-06-27 15:49 ` [PATCH 1/2] Support for $FILENAMES in tool definitions Johannes Schindelin
2016-06-28  8:04   ` Alex Riesen
2016-06-27 17:28 ` Jakub Narębski
2016-06-27 17:53   ` Junio C Hamano
2016-06-27 18:09     ` Jakub Narębski
2016-06-28  8:54   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57716329.8000809@gmail.com \
    --to=jnareb@gmail.com \
    --cc=alexander.riesen@cetitec.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).