git-log fatal error in empty repo

git-log fatal error in empty repo

[Steve Hoelzer]

git-log will return a fatal error for an empty repo, like so:

$ git --version
git version 1.5.2.73.g18bece
$ mkdir mytest
$ cd mytest
$ git-init
Initialized empty Git repository in .git/
$ git-log
fatal: bad default revision 'HEAD'

It would be nice if git-log was quiet or returned a "no log" message
instead of the fatal error.

Steve

Re: git-log fatal error in empty repo

[Junio C Hamano]

"Steve Hoelzer" <shoelzer@gmail.com> writes:

> git-log will return a fatal error for an empty repo, like so:
>
> $ git --version
> git version 1.5.2.73.g18bece
> $ mkdir mytest
> $ cd mytest
> $ git-init
> Initialized empty Git repository in .git/
> $ git-log
> fatal: bad default revision 'HEAD'
>
> It would be nice if git-log was quiet or returned a "no log" message
> instead of the fatal error.

Maybe, but I highly doubt if it is worth to bother about it.

 revision.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/revision.c b/revision.c
index 0a29b53..0573b86 100644
--- a/revision.c
+++ b/revision.c
@@ -1218,8 +1218,11 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 		unsigned char sha1[20];
 		struct object *object;
 		unsigned mode;
-		if (get_sha1_with_mode(def, sha1, &mode))
+		if (get_sha1_with_mode(def, sha1, &mode)) {
+			if (!strcmp("HEAD", def))
+				die("You have no history yet on your HEAD");
 			die("bad default revision '%s'", def);
+		}
 		object = get_reference(revs, def, sha1, 0);
 		add_pending_object_with_mode(revs, object, def, mode);
 	}

Re: git-log fatal error in empty repo

[Geert Bosch]

On Jun 7, 2007, at 16:29, Junio C Hamano wrote:
> Maybe, but I highly doubt if it is worth to bother about it.

My first confusion with git was exactly this issue.
It's very normal for a new user to do a git init
and than try to verify that the current state is a sane
empty repository.

So, git log, git status and git fsck should all properly
handle this situation and give reasonable output in this case.

   -Geert