git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: git@vger.kernel.org, kristofferhaugsbakk@fastmail.com
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH] doc: column: fix blank lines before block delimiters
Date: Sat, 31 May 2025 23:46:42 +0200	[thread overview]
Message-ID: <5891508.DvuYhMxLoT@cayenne> (raw)
In-Reply-To: <b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code@khaugsbakk.name>

On Saturday, 31 May 2025 23:08:09 CEST kristofferhaugsbakk@fastmail.com wrote:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
> 
> 227c4f33a03 (doc: add a blank line around block delimiters,
> 2025-03-09) added blank lines around block delimiters as a
> defensive measure.  For each block you had to mind the con-
> text (like the commit says):
> 
> • Top-level: just add blank lines
> • Block: use list continuation (+)
> 
> But list continuation was used here at the top level, which
> results in literal `+` in the output formats.
> 
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>  Documentation/git-column.adoc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc
> index 5a4f2b6fde9..8e0047214dc 100644
> --- a/Documentation/git-column.adoc
> +++ b/Documentation/git-column.adoc
> @@ -50,7 +50,7 @@ EXAMPLES
>  --------
> 
>  Format data by columns:
> -+
> +
>  ------------
>  $ seq 1 24 | git column --mode=column --padding=5
>  1      4      7      10     13     16     19     22
> @@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5
>  ------------
> 
>  Format data by rows:
> -+
> +
>  ------------
>  $ seq 1 21 | git column --mode=row --padding=5
>  1      2      3      4      5      6      7
> @@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5
>  ------------
> 
>  List some tags in a table with unequal column widths:
> -+
> +
>  ------------
>  $ git tag --list 'v2.4.*' --column=row,dense
>  v2.4.0  v2.4.0-rc0  v2.4.0-rc1  v2.4.0-rc2  v2.4.0-rc3
> 
> base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67

Acked-by: Jean-Noël Avila <jn.avila@free.fr>




  reply	other threads:[~2025-05-31 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31 21:08 [PATCH] doc: column: fix blank lines before block delimiters kristofferhaugsbakk
2025-05-31 21:46 ` Jean-Noël AVILA [this message]
2025-05-31 22:49 ` Kristoffer Haugsbakk
2025-06-01 11:36 ` [PATCH v2] doc: column: fix blank lines around " kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5891508.DvuYhMxLoT@cayenne \
    --to=jn.avila@free.fr \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).