From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpfb1-g21.free.fr (smtpfb1-g21.free.fr [212.27.42.9]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B58F02472B0 for ; Fri, 13 Jun 2025 20:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.27.42.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749845652; cv=none; b=EtMoKjx05z6tJGjNeN9Sz1xRjfwq9mQffafnfU7Phxlh1TSnL4z3Yhn2KqjeI+60osx7D+qwI2CttWoeRQVC4k8Ubko2FK2NuWgYZFNmpdlvitdT5/Rhtk/dNKzJGUDCjC17+hyvJ0m/0EL8SES5sqc4VHh3gHpr7gLxLg0wlSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749845652; c=relaxed/simple; bh=+ilp0AMzNeY1YX+gE8X3jPgS/gMinC2FUbf1+SFyboM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DAjh4gv0ZHmOXVi58U+AygorcYIE/1eyxPIzPURfg03hGjm6nm0yTYcb+Zplqt2bnwhm6aSSfaWM4iD7jlggEsCQ7TcDBU1dUC/wMzIBFcaV2kHiGmkMTxB9jZdRLWrxuH+PGtSMFV+GghEmWOaFl6tUg2HIcrMut7CgHa3dua0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=free.fr; spf=pass smtp.mailfrom=free.fr; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.b=anOz201w; arc=none smtp.client-ip=212.27.42.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=free.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=free.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.b="anOz201w" Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [212.27.42.1]) by smtpfb1-g21.free.fr (Postfix) with ESMTP id 5FA85DF8301 for ; Fri, 13 Jun 2025 22:13:59 +0200 (CEST) Received: from cayenne.localnet (unknown [IPv6:2a01:e0a:d1:f360:5df4:5536:552c:720]) (Authenticated sender: jn.avila@free.fr) by smtp1-g21.free.fr (Postfix) with ESMTPSA id E8167B0053E; Fri, 13 Jun 2025 22:13:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1749845632; bh=+ilp0AMzNeY1YX+gE8X3jPgS/gMinC2FUbf1+SFyboM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=anOz201wjwKvxRY5yspGFy2YagCgtkYw2XfU1DstTzfF9q0+VFNT9RRMVflAYsUfO +yyxKTdpAoOqEUBgnYSakFOJsx6fdYr8FNiG5Sw7jnc9/Tdrmj+awaRb5SpMWaNhCO lUhAZvNwc+wjlunIQzrxmakNyi9ltd8mUoJkrInIfdAE7hidDCkwTXEo6yiSxedBsY BdxIeu8wzkdoE9abAccVtaQiCa2xv7NZjDpyWbw+IF1sjxGhamaudmoysuE3vhWFze saDBySlu70ZbHaq7+/i0cU9ciCDfWZo0cT2UvRRuKGcYrHOkHilTff/+8FomUDlhGm r2ps60afSZT7w== From: =?UTF-8?B?SmVhbi1Ob8OrbA==?= AVILA To: Brad Smith , Collin Funk Cc: Junio C Hamano , git@vger.kernel.org Subject: Re: Solaris sed Date: Fri, 13 Jun 2025 22:13:48 +0200 Message-ID: <5895400.DvuYhMxLoT@cayenne> In-Reply-To: <874iwlegmg.fsf@gmail.com> References: <09f954b8-d9c3-418f-ad4b-9cb9b063f4ae@comstyle.com> <874iwlegmg.fsf@gmail.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Thursday, 12 June 2025 06:19:35 CEST Collin Funk wrote: > Brad Smith writes: > > No errors or warnings after this is applied. > > Likewise. > > I checked on my Linux machine and both files are the same before and > after the patch. Before the patch on Solaris 10, the following is > generated: > > /* Automatically generated by generate-configlist.sh */ > > > static const char *config_name_list[] = { > NULL, > }; > > After the patch the output on Solaris is the same as on Linux. > > So the patch is perfect. > > Reviewed-by: Collin Funk > > Collin Hello, Would it be possible to set up some kind of CI to check for compatibility with such systems. This is the second time I introduced regressions without even knowing it, and it would be really great to catch them before borking a release process. Thanks, JN