From: "Harvey Harrison" <harvey.harrison@gmail.com>
To: "Nicolas Pitre" <nico@cam.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH] fix for "index-pack: rationalize delta resolution code"
Date: Mon, 20 Oct 2008 12:07:54 -0700 [thread overview]
Message-ID: <590657100810201207s9a5f4f5j8572f570928e97c8@mail.gmail.com> (raw)
In-Reply-To: <590657100810201137m477b834cr9c940851b1a599d8@mail.gmail.com>
On Mon, Oct 20, 2008 at 11:37 AM, Harvey Harrison
<harvey.harrison@gmail.com> wrote:
> On Mon, Oct 20, 2008 at 11:12 AM, Nicolas Pitre <nico@cam.org> wrote:
>> My bad. A small detail went through the crack: the real_type of
>> a delta object is the real_type of its base object.
>>
>> Without this, the created index will be wrong as the actual object SHA1
>> won't match the object.
>>
>> Signed-off-by: Nicolas Pitre <nico@cam.org>
>
> This fixes it for me, thanks for the quick fix.
>
> Tested-by: Harvey Harrison <harvey.harrison@gmail.com>
>
Scratch that, it's back to failing again on my next update.
Harvey
next prev parent reply other threads:[~2008-10-20 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 18:12 [PATCH] fix for "index-pack: rationalize delta resolution code" Nicolas Pitre
2008-10-20 18:37 ` Harvey Harrison
2008-10-20 19:07 ` Harvey Harrison [this message]
2008-10-20 19:14 ` Marco Roeland
2008-10-20 19:20 ` Marco Roeland
2008-10-20 19:27 ` Nicolas Pitre
2008-10-20 19:36 ` Marco Roeland
2008-10-20 20:04 ` Nicolas Pitre
2008-10-20 20:12 ` Marco Roeland
2008-10-20 20:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590657100810201207s9a5f4f5j8572f570928e97c8@mail.gmail.com \
--to=harvey.harrison@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).