git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	Josh Soref <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/3] doc: convert git-stash.adoc to synopis style
Date: Fri, 10 Oct 2025 19:43:17 +0200	[thread overview]
Message-ID: <5929880.DvuYhMxLoT@cayenne> (raw)
In-Reply-To: <xmqqsefqah44.fsf@gitster.g>

On Friday, 10 October 2025 17:52:59 CEST Junio C Hamano wrote:
> Jean-Noël Avila <jn.avila@free.fr> writes:
> >>> diff --git a/Documentation/config/stash.adoc b/Documentation/config/
stash.adoc
> >>> index e556105a15..7fc32027f7 100644
> >>> --- a/Documentation/config/stash.adoc
> >>> +++ b/Documentation/config/stash.adoc
> >>> @@ -1,19 +1,28 @@
> >>> -stash.index::
> >>> +ifndef::git-stash[]
> >>> +:see-show: See the description of the 'show' command in linkgit:git-
stash[1].
> >> 
> >> Okay, here you use 'show' and not `show` because this conditional
> >> attribute will pass on `show` and render it as such, not as
> >> inline-verbatim “show”. Bare 'show' is indeed better than bare `show`.
> > 
> > TBH I did not spot the issue when I did this. I wasn't aware that
> > Asciidoc does not automatically handle inline formatting in attributes.
> > But it seems we can force it. This "show" keyword should definitely be
> > inline verbatim.
> > 
> > Wil try and reroll.
> 
> This is already in 'next', isn't it, though?

That's fine. I couldn't come up with a substitution scheme that would work 
correctly for both asciidoc.py and asciidoctor.

So let's just let this patch as it is and recall that attributes are not a 
panacea.



  reply	other threads:[~2025-10-10 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-05 21:11 [PATCH 0/3] doc: convert git-stash, git tag and git worktree to synopis style Jean-Noël Avila via GitGitGadget
2025-10-05 21:11 ` [PATCH 1/3] doc: convert git-stash.adoc " Jean-Noël Avila via GitGitGadget
2025-10-09 23:48   ` Kristoffer Haugsbakk
2025-10-10  6:40     ` Jean-Noël Avila
2025-10-10 15:52       ` Junio C Hamano
2025-10-10 17:43         ` Jean-Noël AVILA [this message]
2025-10-10 18:23           ` Junio C Hamano
2025-10-05 21:11 ` [PATCH 2/3] doc: convert git tag to synopsis style Jean-Noël Avila via GitGitGadget
2025-10-05 21:11 ` [PATCH 3/3] doc: convert git worktree " Jean-Noël Avila via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5929880.DvuYhMxLoT@cayenne \
    --to=jn.avila@free.fr \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).