From: "Kristian Høgsberg" <krh@bitplanet.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] branch as a builtin (again)
Date: Mon, 21 Aug 2006 17:07:43 -0400 [thread overview]
Message-ID: <59ad55d30608211407v74e1369dw17fae16933c0356f@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0608212227040.28360@wbgn013.biozentrum.uni-wuerzburg.de>
On 8/21/06, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Mon, 21 Aug 2006, Kristian Hxgsberg wrote:
>
> > Thanks to all who reviewed the patch, here's an updated version which
> > should address all issues.
>
> I would have preferred the use of path_list instead of rolling your own
> thing with qsort(), but oh well.
Yeah, I saw that, but since I got flack for computing
lookup_commit_reference(head_sha1) inside the delete_branches loop, I
couldn't possibly risk the performance bottle neck of listing the
branches using a O(n^2) insertion sort.
Kristian
next prev parent reply other threads:[~2006-08-21 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 21:22 [PATCH] branch as a builtin (again) Kristian Høgsberg
2006-08-20 23:55 ` Johannes Schindelin
2006-08-21 7:49 ` David Rientjes
2006-08-21 8:03 ` Shawn Pearce
2006-08-21 10:13 ` Jonas Fonseca
2006-08-21 20:12 ` Kristian Høgsberg
2006-08-21 20:23 ` David Rientjes
2006-08-21 20:45 ` Kristian Høgsberg
2006-08-22 7:00 ` Junio C Hamano
2006-08-21 20:27 ` Johannes Schindelin
2006-08-21 21:07 ` Kristian Høgsberg [this message]
[not found] ` <59ad55d30608211337jabd515bra3566fbd0f7ba5a0@mail.gmail.com>
2006-08-21 21:25 ` Johannes Schindelin
2006-08-21 20:41 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ad55d30608211407v74e1369dw17fae16933c0356f@mail.gmail.com \
--to=krh@bitplanet.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).