From: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>,
Harald Nordgren <haraldnordgren@gmail.com>,
Harald Nordgren <haraldnordgren@gmail.com>
Subject: [PATCH v4 4/4] imap-send: match header names case insensitively
Date: Tue, 27 Oct 2026 08:31:19 +0000 [thread overview]
Message-ID: <5b4a08bbdadac95a84f9c865e697584f45bd67af.1793089879.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2456.v4.git.git.1793089879.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>
imap-send says "no messages found to send" for a message whose headers
are spelled "from:", "date:" or "subject:", although RFC 5322 treats
header field names as case insensitive. Match the three names in any
case.
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
imap-send.c | 6 +++---
t/t9001-send-email.sh | 15 +++++++++++++++
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index 706c517e51..b8dac92c70 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1462,11 +1462,11 @@ static bool has_required_headers(const char *line)
bool from = false, date = false, subject = false;
while ((line = strchr(line, '\n')) && *++line != '\n') {
- if (starts_with(line, "From: "))
+ if (istarts_with(line, "From: "))
from = true;
- else if (starts_with(line, "Date: "))
+ else if (istarts_with(line, "Date: "))
date = true;
- else if (starts_with(line, "Subject: "))
+ else if (istarts_with(line, "Subject: "))
subject = true;
}
return from && date && subject;
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 1f77c14315..897473e786 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -2898,4 +2898,19 @@ test_expect_success $PREREQ '--imap-sent-folder stores a copy of the sent patch'
test_grep "(1/1) done" err
'
+test_expect_success $PREREQ 'imap-send matches header names in any case' '
+ test_config imap.tunnel ./fake-imap-server &&
+ cat >lowercase.mbox <<-\EOF &&
+ From mboxrd@z Thu Jan 1 00:00:00 1970
+ from: Example <from@example.com>
+ date: Thu, 1 Jan 1970 00:00:00 +0000
+ subject: [PATCH] lowercase headers
+
+ body
+ EOF
+ git imap-send --folder=INBOX <lowercase.mbox 2>err &&
+ test_grep "^Sending 1 message to INBOX folder" err &&
+ test_grep "(1/1) done" err
+'
+
test_done
--
gitgitgadget
next prev parent reply other threads:[~2026-10-27 8:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 19:19 [PATCH 0/2] Fix imap-send with reordered message headers Harald Nordgren via GitGitGadget
2026-10-19 19:19 ` [PATCH 1/2] imap-send: avoid leaking the tunnel command Harald Nordgren via GitGitGadget
2026-10-19 19:19 ` [PATCH 2/2] imap-send: accept messages with Subject before Date Harald Nordgren via GitGitGadget
2026-10-19 22:00 ` Junio C Hamano
2026-10-20 7:28 ` Harald Nordgren
2026-10-21 7:07 ` [PATCH v2 0/2] Fix imap-send with reordered message headers Harald Nordgren via GitGitGadget
2026-10-21 7:07 ` [PATCH v2 1/2] imap-send: avoid leaking the tunnel command Harald Nordgren via GitGitGadget
2026-10-21 8:24 ` Patrick Steinhardt
2026-10-21 8:53 ` Harald Nordgren
2026-10-21 7:07 ` [PATCH v2 2/2] imap-send: accept messages with Subject before Date Harald Nordgren via GitGitGadget
2026-10-21 8:25 ` Patrick Steinhardt
2026-10-21 8:45 ` Harald Nordgren
2026-10-21 9:36 ` Patrick Steinhardt
2026-10-21 9:59 ` Harald Nordgren
2026-10-22 6:56 ` [PATCH v3 0/4] Fix imap-send with reordered message headers Harald Nordgren via GitGitGadget
2026-10-22 6:56 ` [PATCH v3 1/4] imap-send: wait for the tunnel command to finish Harald Nordgren via GitGitGadget
2026-10-26 9:42 ` Patrick Steinhardt
2026-10-26 9:59 ` Harald Nordgren
2026-10-22 6:56 ` [PATCH v3 2/4] imap-send: accept messages with Subject before Date Harald Nordgren via GitGitGadget
2026-10-22 6:56 ` [PATCH v3 3/4] imap-send: check git send-email copies like other messages Harald Nordgren via GitGitGadget
2026-10-26 9:42 ` Patrick Steinhardt
2026-10-26 10:02 ` Harald Nordgren
2026-10-22 6:56 ` [PATCH v3 4/4] imap-send: match header names case insensitively Harald Nordgren via GitGitGadget
2026-10-26 9:42 ` Patrick Steinhardt
2026-10-27 8:31 ` [PATCH v4 0/4] Fix imap-send with reordered message headers Harald Nordgren via GitGitGadget
2026-10-27 8:31 ` [PATCH v4 1/4] imap-send: wait for the tunnel command to finish Harald Nordgren via GitGitGadget
2026-10-27 8:31 ` [PATCH v4 2/4] imap-send: accept messages with Subject before Date Harald Nordgren via GitGitGadget
2026-10-27 8:31 ` [PATCH v4 3/4] imap-send: check git send-email copies like other messages Harald Nordgren via GitGitGadget
2026-10-27 10:59 ` Patrick Steinhardt
2026-10-27 8:31 ` Harald Nordgren via GitGitGadget [this message]
2026-10-27 10:59 ` [PATCH v4 0/4] Fix imap-send with reordered message headers Patrick Steinhardt
2026-10-29 14:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4a08bbdadac95a84f9c865e697584f45bd67af.1793089879.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=haraldnordgren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox