From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: "René Scharfe" <l.s.r@web.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] nedmalloc: work around overzealous GCC 6 warning
Date: Fri, 5 Aug 2016 07:36:50 +0200 [thread overview]
Message-ID: <5ce2ec67-aa7d-0079-54fe-d73a70a46825@kdbg.org> (raw)
In-Reply-To: <xmqqk2fwyx8h.fsf@gitster.mtv.corp.google.com>
Am 05.08.2016 um 00:39 schrieb Junio C Hamano:
> @@ -955,12 +955,10 @@ void **nedpindependent_comalloc(nedpool *p, size_t elems, size_t *sizes, void **
> */
> char *strdup(const char *s1)
> {
> - char *s2 = 0;
> - if (s1) {
> - size_t len = strlen(s1) + 1;
> - s2 = malloc(len);
> + size_t len = strlen(s1) + 1;
> + s2 = malloc(len);
> + if (s1)
It does not make sense to check s1 for NULL when it was passed to
strlen() earlier; strlen() does not accept NULL, either...
> memcpy(s2, s1, len);
> - }
> return s2;
> }
> #endif
-- Hannes
next prev parent reply other threads:[~2016-08-05 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 16:07 [PATCH 0/2] Patches to let Git build with GCC 6 and DEVELOPER=SureWhyNot Johannes Schindelin
2016-08-04 16:07 ` [PATCH 1/2] nedmalloc: fix misleading indentation Johannes Schindelin
2016-08-04 16:07 ` [PATCH 2/2] nedmalloc: work around overzealous GCC 6 warning Johannes Schindelin
2016-08-04 17:41 ` Junio C Hamano
2016-08-05 15:38 ` Johannes Schindelin
2016-08-04 21:56 ` René Scharfe
2016-08-04 22:33 ` Junio C Hamano
2016-08-04 22:39 ` Junio C Hamano
2016-08-05 5:36 ` Johannes Sixt [this message]
2016-08-05 5:40 ` Johannes Sixt
2016-08-05 6:24 ` Junio C Hamano
2016-08-05 7:42 ` Jeff King
2016-08-05 15:34 ` Johannes Schindelin
2016-08-05 16:13 ` Junio C Hamano
2016-08-06 8:19 ` Johannes Schindelin
2016-08-05 21:57 ` Junio C Hamano
2016-08-05 22:30 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce2ec67-aa7d-0079-54fe-d73a70a46825@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).