From: "Govind Salinas" <govind@sophiasuchtig.com>
To: "Git Mailing List" <git@vger.kernel.org>
Subject: [PATCH] pretty.c: add %z specifier.
Date: Thu, 20 Mar 2008 19:45:26 -0500 [thread overview]
Message-ID: <5d46db230803201745mb736e98w4925e14b5d92d71d@mail.gmail.com> (raw)
This adds a %z format which prints out a null character. This allows for
easier machine parsing of multiline data. It is also necessary to use write
to print out the data since printf will terminate at a null. That in turn
requires that an fflush be executed before the write to preserve the order
the data is printed.
Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
---
log-tree.c | 7 +++++--
pretty.c | 3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/log-tree.c b/log-tree.c
index 608f697..e116a1f 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -308,8 +308,11 @@ void show_log(struct rev_info *opt, const char *sep)
if (opt->show_log_size)
printf("log size %i\n", (int)msgbuf.len);
- if (msgbuf.len)
- printf("%s%s%s", msgbuf.buf, extra, sep);
+ if (msgbuf.len) {
+ fflush(stdout);
+ write(STDOUT_FILENO, msgbuf.buf, msgbuf.len);
+ printf("%s%s", extra, sep);
+ }
strbuf_release(&msgbuf);
}
diff --git a/pretty.c b/pretty.c
index 703f521..fd155ec 100644
--- a/pretty.c
+++ b/pretty.c
@@ -478,6 +478,9 @@ static size_t format_commit_item(struct strbuf
*sb, const char *placeholder,
case 'n': /* newline */
strbuf_addch(sb, '\n');
return 1;
+ case 'z': /* null */
+ strbuf_addch(sb, '\0');
+ return 1;
}
/* these depend on the commit */
--
1.5.4.4.552.g9987b
next reply other threads:[~2008-03-21 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 0:45 Govind Salinas [this message]
2008-03-21 2:13 ` [PATCH] pretty.c: add %z specifier Jeff King
2008-03-21 4:48 ` Junio C Hamano
2008-03-21 4:51 ` Jeff King
2008-03-21 5:09 ` Junio C Hamano
2008-03-21 5:42 ` Govind Salinas
2008-03-21 5:50 ` David Symonds
2008-03-21 6:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d46db230803201745mb736e98w4925e14b5d92d71d@mail.gmail.com \
--to=govind@sophiasuchtig.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).