git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Govind Salinas" <blix@sophiasuchtig.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PYRITE] Status update and call for information.
Date: Fri, 23 May 2008 07:36:25 -0500	[thread overview]
Message-ID: <5d46db230805230536r18ac606j93a210d0b2864719@mail.gmail.com> (raw)
In-Reply-To: <20080523064541.GA31315@diana.vm.bytemark.co.uk>

On Fri, May 23, 2008 at 1:45 AM, Karl Hasselström <kha@treskal.com> wrote:
> On 2008-05-23 01:18:42 -0500, Govind Salinas wrote:
>
>> Some functionality isn't for everyone. I have just put into my next
>> branch an addon that gives git revision numbers. Why, because other
>> SCMs that are supposed to be more user friendly have them. Because
>> people have been asking for them. Because they are easier to
>> remember. The concept is this. A given commit encapsulates its
>> parantage, so if I have commit XYZ, I can always say that XYZ is
>> so-many commits away from the first commit. The question is how you
>> determine that number and that you always do it the same. If we just
>> define the revision number to be the place of the commit in the list
>> of "git rev-list --topo-order --reverse SHA1" then we can get a
>> consistant number semi-meaningful number, which is all people really
>> want.
>
> You do realize that no matter how you define your sequential numbers,
> they can't be both globally consistent and unique? (That is, either
> different repositories will assign different numbers to the same
> commit, or the same number could be assigned to more than one commit.)
>
> For a simple reason: A numbering that's both globally consistent and
> unique can only look at a commit's ancestry (and the commit itself)
> when assigning a number to a commit. But in order to get _sequential_
> numbers, you need to look at the commit's siblings as well, and the
> set of siblings can be different from repository to repository.
>
> This has already been discussed to death elsewhere in this list at
> least once (see the list archives), but your next paragraph suggests
> you think it's only a performance issue, which is why I brought it up:
>

Of course, no one makes the claim that rev numbers are unique or
even that a commit has the same revision number between branches
in the same repository.   Hg states that flat out and I believe bzr says
the same, although I am pretty sure they determine their numbers some
other way.  I make no such claim.  What I do claim is that for a given
branch, a commit should always have the same revision number.  Sure,
If you merge a commit from another branch, it's revnum might change,
but that is ok.  As long as, assuming you have not re-written master,
10:master will always point to the same commit I think I am providing
something worth while.  Also, AFAIK the order of parentage is part of
the hash that makes a commit ID, so if my master is a clone of your
master, it should share revision numbers.

Thanks,
Govind.

  reply	other threads:[~2008-05-23 12:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23  6:18 [PYRITE] Status update and call for information Govind Salinas
2008-05-23  6:45 ` Karl Hasselström
2008-05-23 12:36   ` Govind Salinas [this message]
2008-05-23 13:12     ` Karl Hasselström
2008-05-24  1:07 ` Jakub Narebski
2008-05-24  5:16   ` Govind Salinas
2008-05-24  8:41     ` Jakub Narebski
2008-05-24 17:43       ` Govind Salinas
2008-05-24 23:27         ` Jakub Narebski
2008-05-25  9:23         ` Jan Krueger
2008-05-25 18:22           ` Govind Salinas
2008-05-24 19:59     ` Dmitry Potapov
2008-05-24 20:47       ` Jakub Narebski
2008-05-24 21:50         ` Govind Salinas
2008-05-25 11:35           ` Jakub Narebski
2008-05-25 19:03             ` Govind Salinas
2008-05-24 19:57   ` Dmitry Potapov
2008-05-24 22:23     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d46db230805230536r18ac606j93a210d0b2864719@mail.gmail.com \
    --to=blix@sophiasuchtig.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).