From: "Govind Salinas" <govind@sophiasuchtig.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: "Elijah Newren" <newren@gmail.com>,
"Steven Walter" <stevenrwalter@gmail.com>,
git@vger.kernel.org
Subject: Re: Revert behavior [Was: Re: [ANNOUNCE] yap: Yet Another (Git) Porcelain]
Date: Tue, 9 Sep 2008 11:37:40 -0500 [thread overview]
Message-ID: <5d46db230809090937k44fc569ct7eda35b9ee86cb22@mail.gmail.com> (raw)
In-Reply-To: <200809091538.13961.jnareb@gmail.com>
On Tue, Sep 9, 2008 at 8:38 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> Elijah Newren wrote:
>> On Mon, Sep 8, 2008 at 10:25 PM, Govind Salinas
>> <govind@sophiasuchtig.com> wrote:
>> > On Mon, Sep 8, 2008 at 8:05 PM, Steven Walter <stevenrwalter@gmail.com> wrote:
>>
>> > I had some very different ideas along the lines of reducing the number of
>> > commands (where the commands do something similar just DWIM rather
>> > than force me to remember or read docs on different commands), making
>> > commands look similar to commands from other SCMs (revert should do
>> > what it does for me in all the other SCMs that I have used, which is to
>> > checkout the HEAD copy into the working directory)
>>
>> Your description of revert in various systems isn't quite accurate; it
>> isn't necessarily HEAD, since most systems (at least bzr and hg) can
>> also revert files to revisions earlier than HEAD. In fact, questions
>> of how to do that have come up several times on this list, so you
>> wouldn't want to exclude that case. Also, the revert behavior of git
>> (minus perhaps the default auto-commit) comes in pretty handy too
>> sometimes, and I can't easily find it in other systems (I suspect many
>> just drop back to diff + patch to handle the case that git provides).
> [...]
>
> By the way, I think the fact that in different SCMs meaning of
> "$scm revert" and of "$scm reset" differs widely caused Mercurial
> to adopt "hg backout" for creating a commit which reverts changes
> (cherry-pick -R), and "hg rollback" to undo last commit.
>
My take on this comes from my own personal experience with "revert"
commands, the fact that "how do i undo my working dir changes" is
the most common question I see on the list and that I have heard
others with the same complaint.
I will concede that revert usually means both "discard current working
dir changes" and "undo a previous change" in different circumstances.
However, the number of times that "how do i discard my working
dir changes" comes up on the list leads me to believe that you get
the most out of using revert for this, since it is something that should
be familiar to a user and undoing a previous commit is more rare.
Of course, this is where I would use a DWIM-ism.
"pyt revert -r commitish" would generate a reverse patch but
"pyt revert <paths>..." would checkout from HEAD. "pyt revert" would
just "git reset --hard".
-Govind
next prev parent reply other threads:[~2008-09-09 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 13:26 Revert behavior [Was: Re: [ANNOUNCE] yap: Yet Another (Git) Porcelain] Elijah Newren
2008-09-09 13:38 ` Jakub Narebski
2008-09-09 16:37 ` Govind Salinas [this message]
2008-09-09 17:29 ` Steven Walter
2008-09-09 20:19 ` Elijah Newren
2008-09-09 21:50 ` Steven Walter
2008-09-09 23:02 ` Elijah Newren
2008-09-09 20:20 ` Elijah Newren
2008-09-09 21:28 ` Petr Baudis
2008-09-09 21:39 ` Steven Walter
2008-09-09 22:10 ` Revert behavior Junio C Hamano
2008-09-09 22:30 ` Steven Walter
2008-09-09 22:51 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d46db230809090937k44fc569ct7eda35b9ee86cb22@mail.gmail.com \
--to=govind@sophiasuchtig.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=newren@gmail.com \
--cc=stevenrwalter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).