From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: Adam Dinwoodie <adam@dinwoodie.org>, git@vger.kernel.org
Subject: Re: [PATCH] crlf: Add test showing double warning on commit
Date: Sun, 15 May 2016 08:46:32 +0200 [thread overview]
Message-ID: <5e47eb63-41b3-31d0-7781-04d4e6eeb4b8@web.de> (raw)
In-Reply-To: <xmqqoa887a25.fsf@gitster.mtv.corp.google.com>
On 14.05.16 20:45, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> Do we need to run diff_populate_filespec() twice when src==dst ?
>
> Of course we do.
>
> src and dst may have the same path, but are coming from different
> places (src may be an indexed blob while dst may be a file in the
> working tree).
>
>> If yes, we may need to introduce a flag besides
>> #define CHECK_SIZE_ONLY 1
>> #define CHECK_BINARY 2
>> to suppress the conversion warning ??
>
> I do not think that belongs to diff_populate_filespec() at all.
Just to remind myself:
sha1_file.c:
The warning should probably triggered from here, depending on the flags ?
int index_fd(unsigned char *sha1, int fd, struct stat *st,
enum object_type type, const char *path, unsigned flags)
prev parent reply other threads:[~2016-05-15 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 11:17 [PATCH] crlf: Add test showing double warning on commit Adam Dinwoodie
2016-05-14 16:20 ` Torsten Bögershausen
2016-05-14 18:45 ` Junio C Hamano
2016-05-15 6:39 ` Torsten Bögershausen
2016-05-15 18:55 ` Junio C Hamano
2016-05-15 6:46 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e47eb63-41b3-31d0-7781-04d4e6eeb4b8@web.de \
--to=tboegi@web.de \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).