[PATCH 0/1] freshen_file(): use NULL `times' for implicit current-time

[luciano.rocha@booking.com]

Hi all,

Currently freshen_file() consists of:
  struct utimbuf t;
  t.actime = t.modtime = time(NULL);
  return !utime(fn, &t);

That, however, is permitted only on files that the user owns (for normal
users).

So on a shared repo with split-index enabled, we end up with the
warning:
  $ git status
  warning: could not freshen shared index '.git/sharedindex.bd736fa10e0519593fefdb2aec253534470865b2'

The following gives the same end result (updated atime and mtime), and
is also allowed for any file the user has permissions to write to:

  return !utime(fn, NULL);

So the following patch changes it to that.

I'm unaware of any system where those two are not equivalent except for
the permisison check.

Luciano Rocha (1):
  freshen_file(): use NULL `times' for implicit current-time

 sha1-file.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Regards,
Luciano Rocha

-- 
2.26.0