From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH] more oideq/hasheq conversions
Date: Tue, 2 Oct 2018 17:34:32 -0400 [thread overview]
Message-ID: <5f28c9d1-1fed-5af4-c6fb-c05d90d125c2@gmail.com> (raw)
In-Reply-To: <20181002211921.GA3322@sigill.intra.peff.net>
On 10/2/2018 5:19 PM, Jeff King wrote:
> We added faster equality-comparison functions for hashes in
> 14438c4497 (introduce hasheq() and oideq(), 2018-08-28). A
> few topics were in-flight at the time, and can now be
> converted. This covers all spots found by "make coccicheck"
> in master (the coccicheck results were tweaked by hand for
> style).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Jake: I was surprised that this was not a "patch 2" on top of your
> earlier coccicheck patch. Apologies if you were planning to send it out.
>
> This doesn't conflict with anything in "pu", so it's a reasonable time
> to apply it. There are a few lingering cases in pu, so another option is
> to wait a week or two and see if they get merged.
These conversions look good to me!
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
next prev parent reply other threads:[~2018-10-02 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 21:19 [PATCH] more oideq/hasheq conversions Jeff King
2018-10-02 21:34 ` Derrick Stolee [this message]
2018-10-02 23:46 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f28c9d1-1fed-5af4-c6fb-c05d90d125c2@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).