From: "Jim Raden" <james.raden@gmail.com>
To: johannes.sixt@telecom.at
Cc: "Junio C Hamano" <gitster@pobox.com>,
msysGit <msysgit@googlegroups.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: MinGW port pull request
Date: Sat, 21 Jun 2008 17:21:47 -0400 [thread overview]
Message-ID: <5fc54b450806211421m64eee6e5l3622243e65f633a2@mail.gmail.com> (raw)
In-Reply-To: <200806212318.47745.johannes.sixt@telecom.at>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Sat, Jun 21, 2008 at 5:18 PM, Johannes Sixt <johannes.sixt@telecom.at>
wrote:
>
> > * There are still too many ifdefs. I am wondering if the changes to
> > pager and process stuff is easier to manage in the longer term if they
> > are made into completely separate files (i.e. instead of linking
> > pager.o you would link mingw-pager.o). I dunno.
>
> I think that would not be helpful. Both parts need to be maintained,
> whether
> they are in the same file or in different files. If they are in one file,
> and
> someone needs to make a change, then there is a chance that a corresponding
> change is made in the MINGW32 arm. If not then there is another chance that
> the person would at least say "I don't know how to do it for MINGW32". But
> if
> you separate the implementations completely, then both chances are missed
> much easier.
>
> I quite agree!!
[-- Attachment #2: Type: text/html, Size: 1256 bytes --]
next prev parent reply other threads:[~2008-06-21 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 8:06 MinGW port pull request Johannes Sixt
2008-06-21 9:46 ` Junio C Hamano
2008-06-21 21:18 ` [msysGit] " Johannes Sixt
2008-06-21 21:21 ` Jim Raden [this message]
2008-06-21 21:47 ` Junio C Hamano
2008-06-23 11:54 ` Johannes Sixt
2008-06-24 13:01 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc54b450806211421m64eee6e5l3622243e65f633a2@mail.gmail.com \
--to=james.raden@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).