git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>,
	'Junio C Hamano' <gitster@pobox.com>,
	'Christian Couder' <christian.couder@gmail.com>
Cc: 'git' <git@vger.kernel.org>
Subject: RE: [ANNOUNCE] Git v2.30.0-rc2
Date: Thu, 24 Dec 2020 09:16:52 -0600	[thread overview]
Message-ID: <5fe4b0e45fb85_19c9208c8@natae.notmuch> (raw)
In-Reply-To: <00ed01d6da03$f8928fc0$e9b7af40$@nexbridge.com>

Randall S. Becker wrote:
> On December 24, 2020 1:36 AM, Junio C Hamano wrote:
> > Junio C Hamano <gitster@pobox.com> writes:
> > 
> > > Christian Couder <christian.couder@gmail.com> writes:
> > >
> > >> Most of the suggestions below are found by GMail.
> > >>
> > >> On Thu, Dec 24, 2020 at 12:08 AM Junio C Hamano <gitster@pobox.com>
> > wrote:
> > >>>
> > >>> A release candidate Git v2.30.0-rc2 is now available for testing at
> > >>> the usual places.  It is comprised of 19 non-merge commits since
> > >>
> > >> Maybe: s/is comprised of/comprises/
> > >
> > > Funny.
> > >
> > > I do recall somebody else (perhaps Peff but I may be misremembering)
> > > helped me grammofixing the use of verb "comprise" in the sentence when
> > > I started listing the names of commit authors back in v2.3.3 or
> > > v2.4.0 era.  Perhaps I failed to follow the advice given?  I dunno.
> 
> NonStop test cycle in progress on both platforms.
> 
> And "comprises" is considered correct as the present tense according to
> Merriam-Webster. "Is comprised of" is more formal and tends to get edited
> down to "comprises" by current grammar checkers to reduce use of the passive
> form of verbs that pervades technical documents and thesis papers.

Techically it's wrong [1]:

"The whole comprises the parts; thus is comprised of is wrong."

But many people use it, so it's not *that* wrong.

[1] https://www.merriam-webster.com/words-at-play/can-you-use-comprised-of-grammar

-- 
Felipe Contreras

      reply	other threads:[~2020-12-24 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 23:05 [ANNOUNCE] Git v2.30.0-rc2 Junio C Hamano
2020-12-24  0:22 ` Todd Zullinger
2020-12-24  0:48   ` Junio C Hamano
2020-12-24  6:13 ` Christian Couder
2020-12-24  6:28   ` Junio C Hamano
2020-12-24  6:36     ` Junio C Hamano
2020-12-24 14:49       ` Randall S. Becker
2020-12-24 15:16         ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fe4b0e45fb85_19c9208c8@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).