From: Felipe Contreras <felipe.contreras@gmail.com>
To: "阿德烈 via GitGitGadget" <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: 阿德烈 <adlternative@gmail.com>, "ZheNing Hu" <adlternative@gmail.com>
Subject: RE: [PATCH] builtin/*: update usage format
Date: Tue, 29 Dec 2020 08:33:50 -0600 [thread overview]
Message-ID: <5feb3e4eda10e_3ed2e20830@natae.notmuch> (raw)
In-Reply-To: <pull.822.git.1609232114080.gitgitgadget@gmail.com>
阿德烈 via GitGitGadget wrote:
> From: ZheNing Hu <adlternative@gmail.com>
>
> According to the "Error Messages" section of
> Documentation/CodingGuidelines, we should not end in a full
> stop or start with a capital letter. Fix old error and usage
> messages to match this expectation.
I agree this consistency is good.
The only time where you need capital letters and full stops is when
there's multiple sentences.
--
Felipe Contreras
next prev parent reply other threads:[~2020-12-29 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 8:55 [PATCH] builtin/*: update usage format 阿德烈 via GitGitGadget
2020-12-29 14:33 ` Felipe Contreras [this message]
2021-01-06 7:05 ` Re* " Junio C Hamano
2021-01-06 12:03 ` Derrick Stolee
2021-01-06 11:51 ` [PATCH v2 0/2] " 阿德烈 via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 1/2] " ZheNing Hu via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 2/2] parse-options: format argh like error messages Junio C Hamano via GitGitGadget
2021-01-06 12:05 ` Derrick Stolee
2021-01-06 14:44 ` [PATCH v3 0/2] builtin/*: update usage format 阿德烈 via GitGitGadget
2021-01-06 14:44 ` [PATCH v3 1/2] parse-options: format argh like error messages Junio C Hamano via GitGitGadget
2021-01-06 14:44 ` [PATCH v3 2/2] builtin/*: update usage format ZheNing Hu via GitGitGadget
2021-01-06 23:14 ` [PATCH v3 0/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5feb3e4eda10e_3ed2e20830@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).