From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Martin Ågren" <martin.agren@gmail.com>,
"Thomas Ackermann via GitGitGadget" <gitgitgadget@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Thomas Ackermann <th.acker@arcor.de>
Subject: Re: [PATCH] doc: fix some typos
Date: Sat, 02 Jan 2021 16:26:27 -0600 [thread overview]
Message-ID: <5ff0f31315732_a76d20833@natae.notmuch> (raw)
In-Reply-To: <CAN0heSojPyr=g5PBVmT4VTfxxKxzYcFXJ1jynM1tGuZSyQMykg@mail.gmail.com>
Martin Ågren wrote:
> On Sat, 2 Jan 2021 at 18:43, Thomas Ackermann via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>
> [Snip several typo fixes in Documentation/, all of which I agree with.]
>
> > diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
> > index c151dd7257f..8f77baa678f 100644
> > --- a/contrib/buildsystems/CMakeLists.txt
> > +++ b/contrib/buildsystems/CMakeLists.txt
>
> Hmm... This does not match the "doc:" prefix of the patch.
>
> > @@ -442,7 +442,7 @@ endif()
> > check_c_source_compiles("
> > #include <regex.h>
> > #ifndef REG_STARTEND
> > -#error oops we dont have it
> > +#error oops we don't have it
> > #endif
>
> I don't think this is correct. This omission of the single quote somehow
> looks like it's done on purpose. I don't build using this system, but I
> tried making some silly code like this in another file, which I actually
> do use:
>
> #if 0
> #error might or mightn't work
> #endif
But this works:
#error "might or mightn't work"
--
Felipe Contreras
next prev parent reply other threads:[~2021-01-02 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 17:40 [PATCH] doc: fix some typos Thomas Ackermann via GitGitGadget
2021-01-02 21:53 ` Martin Ågren
2021-01-02 22:26 ` Felipe Contreras [this message]
2021-01-02 22:59 ` Martin Ågren
2021-01-02 23:40 ` Felipe Contreras
2021-01-03 14:50 ` Chris Torek
2021-01-03 14:25 ` [PATCH v2] " Thomas Ackermann via GitGitGadget
2021-01-03 17:06 ` Martin Ågren
2021-01-06 6:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff0f31315732_a76d20833@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=th.acker@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).