From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org
Subject: Re: The top 1% of commit trailers
Date: Wed, 26 May 2021 03:05:37 -0500 [thread overview]
Message-ID: <60ae0151b4df8_34e96208d0@natae.notmuch> (raw)
In-Reply-To: <24504f19-eb8e-c725-723a-22efea7c865c@gmail.com>
Bagas Sanjaya wrote:
> On 26/05/21 05.09, Felipe Contreras wrote:
> > Total wealth: 1%
> >
> > [1] https://gist.github.com/felipec/ce491d351c88e4acbdbf6bc02a47223d
>
> Why did you deliberately exclude Signed-off-by trailer? I don't see
> that trailer above.
Because it's in a completely different class. It is mandatory, and we
all know it's #1, by far.
In the wealth analogy Signed-off-by is a king; so far away from anybody
else it's not even worth contemplating.
> For some trailers that have only 1 occurrence, these are typos of
> intended trailers (such as heled-by and helpd-by which means
> helped-by).
Indeed. I had code in place to fix those, but then I decided against
that because they exemplify a crucial part of language; mistakes happen.
It would be cheating to hide that truth.
Heled-by is now part of the history, just like
Simplified-testcase-and-bisection-by, and I'm not going to try to hide
either of those.
Cheers.
--
Felipe Contreras
prev parent reply other threads:[~2021-05-26 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 22:09 The top 1% of commit trailers Felipe Contreras
2021-05-26 4:54 ` Bagas Sanjaya
2021-05-26 8:05 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ae0151b4df8_34e96208d0@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).