From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: Only 27% of reviewed-by tags are explicit, and much more
Date: Fri, 18 Jun 2021 11:05:45 -0500 [thread overview]
Message-ID: <60ccc459c5dd8_5eaa22086e@natae.notmuch> (raw)
In-Reply-To: <35417819-3b25-e346-436a-a2090a8f8c43@gmail.com>
Bagas Sanjaya wrote:
> On 18/06/21 10.47, Felipe Contreras wrote:
> > I think it's fair to say our Documentation/SubmittingPatches needs to be
> > updated.
>
> With what new procedure? After any reviews?
Something like this:
. `Reviewed-by:`, means the reviewer is completely satisfied with the
patch after a detailed analysis. Unlike other tags, it's recommended
that the reviewers themselves offer it.
It is recommended, not a must.
--
Felipe Contreras
prev parent reply other threads:[~2021-06-18 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 3:47 Only 27% of reviewed-by tags are explicit, and much more Felipe Contreras
2021-06-18 5:05 ` Eric Sunshine
2021-06-18 16:00 ` Felipe Contreras
2021-06-19 7:00 ` Eric Sunshine
2021-06-19 21:45 ` Felipe Contreras
2021-06-18 5:56 ` Bagas Sanjaya
2021-06-18 16:05 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ccc459c5dd8_5eaa22086e@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).