From: Felipe Contreras <felipe.contreras@gmail.com>
To: Philip Oakley <philipoakley@iee.email>,
Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org
Cc: "Vít Ondruch" <vondruch@redhat.com>,
"Jacob Keller" <jacob.keller@gmail.com>,
"Alex Henrie" <alexhenrie24@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Elijah Newren" <newren@gmail.com>
Subject: Re: [PATCH 1/2] doc: pull: explain what is a fast-forward
Date: Thu, 24 Jun 2021 14:05:02 -0500 [thread overview]
Message-ID: <60d4d75e7622c_242620854@natae.notmuch> (raw)
In-Reply-To: <c2170f74-b93b-599b-1fb4-45b013c7bff1@iee.email>
Philip Oakley wrote:
> Hi Felipe,
> On 24/06/2021 15:31, Felipe Contreras wrote:
> > Philip Oakley wrote:
> >> On 21/06/2021 18:52, Felipe Contreras wrote:
> >>> --- a/Documentation/git-pull.txt
> >>> +++ b/Documentation/git-pull.txt
> >>> @@ -41,16 +41,41 @@ Assume the following history exists and the current branch is
> >>> ------------
> >>> A---B---C master on origin
> >>> /
> >>> - D---E---F---G master
> >>> + D---E master
> >>> ^
> >>> origin/master in your repository
> >>> ------------
> >>>
> >>> Then "`git pull`" will fetch and replay the changes from the remote
> >>> `master` branch since it diverged from the local `master` (i.e., `E`)
> >>> -until its current commit (`C`) on top of `master` and record the
> >>> -result in a new commit along with the names of the two parent commits
> >>> -and a log message from the user describing the changes.
> >>> +until its current commit (`C`) on top of `master`.
> >>> +
> >>> +After the remote changes have been synchronized, the local `master` will
> >>> +be fast-forwarded to the same commit as the remote one, therefore
> >> Perhaps s/be fast-forwarded/have been 'fast-forward'ed/ ?
> > No, there's multiple steps:
> My key point was to 'quote' the fast-forward term.
fast-forward is an English word [1], there's no need to quote it as if
it weren't.
> And then (if suitable, with appropriate grammar corrections) indicate
> subtly that 'nothing actually moved', we just moved the post-it note
> showing the branch-name on the DAG [hence the confusion about timing] ;-)
A branch is a "post-it note", moving the post-it note is the same thing
as moving the branch.
Both the "origin/master" branch, and the "master" branch moved. So I
don't know how exactly "nothing actually moved".
Perhaps you meant no commit was created, and therefore the DAG didn't
change.
Maybe instead of saying "creating a linear history", "representing a
linear history"?
[1] https://www.merriam-webster.com/dictionary/fast-forward
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-24 19:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 17:52 [PATCH 0/2] pull: documentation improvements Felipe Contreras
2021-06-21 17:52 ` [PATCH 1/2] doc: pull: explain what is a fast-forward Felipe Contreras
2021-06-22 5:51 ` Bagas Sanjaya
2021-06-23 1:11 ` Felipe Contreras
2021-06-24 14:21 ` Philip Oakley
2021-06-24 14:31 ` Felipe Contreras
2021-06-24 16:59 ` Philip Oakley
2021-06-24 19:05 ` Felipe Contreras [this message]
2021-06-24 22:07 ` Philip Oakley
2021-06-24 23:41 ` Felipe Contreras
2021-06-25 9:12 ` Ævar Arnfjörð Bjarmason
2021-06-25 10:47 ` Felipe Contreras
2021-06-25 10:59 ` Ævar Arnfjörð Bjarmason
2021-06-25 15:49 ` Felipe Contreras
2021-06-25 16:53 ` Kerry, Richard
2021-06-25 17:34 ` Felipe Contreras
2021-06-25 21:36 ` Felipe Contreras
2021-06-21 17:52 ` [PATCH 2/2] pull: improve default warning Felipe Contreras
2021-06-21 18:05 ` Alex Henrie
2021-06-21 18:51 ` Felipe Contreras
2021-06-21 21:47 ` Alex Henrie
2021-06-21 22:12 ` Felipe Contreras
2021-06-22 3:15 ` Alex Henrie
2021-06-22 4:26 ` Felipe Contreras
2021-06-22 15:06 ` Elijah Newren
2021-06-22 21:22 ` Alex Henrie
2021-06-23 2:20 ` Elijah Newren
2021-06-23 4:18 ` Felipe Contreras
2021-06-23 6:47 ` Elijah Newren
2021-06-23 17:24 ` Felipe Contreras
2021-06-23 1:09 ` Felipe Contreras
2021-06-23 7:54 ` Elijah Newren
2021-06-23 18:19 ` Felipe Contreras
2021-06-24 3:38 ` Alex Henrie
2021-06-24 5:55 ` Felipe Contreras
2021-06-27 0:17 ` Alex Henrie
2021-06-27 4:21 ` Felipe Contreras
2021-06-23 0:48 ` [PATCH v2 0/2] pull: documentation improvements Felipe Contreras
2021-06-23 0:48 ` [PATCH v2 1/2] doc: pull: explain what is a fast-forward Felipe Contreras
2021-06-23 0:48 ` [PATCH v2 2/2] pull: improve default warning Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d4d75e7622c_242620854@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.email \
--cc=vondruch@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).