From: Felipe Contreras <felipe.contreras@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>, git@vger.kernel.org
Cc: Christian Couder <christian.couder@gmail.com>
Subject: RE: [PATCH] help: convert git_cmd to page in one place
Date: Sat, 26 Jun 2021 12:57:35 -0500 [thread overview]
Message-ID: <60d76a8f5d2d6_1740d20882@natae.notmuch> (raw)
In-Reply-To: <20210626163219.4137317-1-rybak.a.v@gmail.com>
Andrei Rybak wrote:
> Depending on the chosen format of help pages, git-help uses function
> show_man_page, show_info_page, or show_html_page. The first thing all
> three functions do is to convert given `git_cmd` to a `page` using
> function cmd_to_page.
>
> Move the common part of these three functions to function cmd_help to
> avoid code duplication.
Makes sense.
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-26 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:32 [PATCH] help: convert git_cmd to page in one place Andrei Rybak
2021-06-26 17:57 ` Felipe Contreras [this message]
2021-07-04 15:39 ` [PATCH resend] " Andrei Rybak
2021-07-05 6:15 ` Ævar Arnfjörð Bjarmason
2021-07-06 20:11 ` Junio C Hamano
2021-07-08 8:07 ` Andrei Rybak
2021-07-08 15:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d76a8f5d2d6_1740d20882@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).