From: Felipe Contreras <felipe.contreras@gmail.com>
To: Hu Jialun <hujialun@comp.nus.edu.sg>, git@vger.kernel.org
Cc: gitster@pobox.com, Hu Jialun <hujialun@comp.nus.edu.sg>
Subject: RE: [PATCH v2 2/2] commit: remove irrelavent prompt on `--allow-empty-message`
Date: Wed, 07 Jul 2021 12:42:58 -0500 [thread overview]
Message-ID: <60e5e7a2d2ddf_30143720855@natae.notmuch> (raw)
In-Reply-To: <20210707162308.2438170-3-hujialun@comp.nus.edu.sg>
Hu Jialun wrote:
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -918,7 +918,9 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
> if (cleanup_mode == COMMIT_MSG_CLEANUP_ALL) {
> status_printf_ln(s, GIT_COLOR_NORMAL, msg_enter_prompt);
> status_printf_ln(s, GIT_COLOR_NORMAL, ignore_char_prompt, comment_line_char);
> - status_printf_ln(s, GIT_COLOR_NORMAL, empty_msg_abort_prompt);
> + if (!allow_empty_message) {
> + status_printf_ln(s, GIT_COLOR_NORMAL, empty_msg_abort_prompt);
> + }
In git the style is to avoid braces if the content of the condition is a
single line.
--
Felipe Contreras
next prev parent reply other threads:[~2021-07-07 17:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 2:24 [PATCH] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-06 15:44 ` Junio C Hamano
2021-07-07 4:37 ` Felipe Contreras
2021-07-07 10:43 ` Hu Jialun
2021-07-07 16:23 ` Hu Jialun
2021-07-07 16:23 ` [PATCH v2 1/2] commit: reorganise duplicate commit prompt strings Hu Jialun
2021-07-07 16:57 ` Đoàn Trần Công Danh
2021-07-07 17:44 ` Junio C Hamano
2021-07-07 16:23 ` [PATCH v2 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-07 17:42 ` Felipe Contreras [this message]
2021-07-08 15:19 ` [PATCH] " Hu Jialun
2021-07-08 16:05 ` Đoàn Trần Công Danh
2021-07-08 18:26 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 1/2] commit: reorganise commit hint strings Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-09 18:07 ` [PATCH v3 2/2] commit: remove irrelavent prompt on `--allow-empty-message` Hu Jialun
2021-07-09 19:14 ` Junio C Hamano
2021-07-10 17:26 ` Hu Jialun
2021-07-22 18:33 ` Hu Jialun
2021-07-22 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e5e7a2d2ddf_30143720855@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hujialun@comp.nus.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).