Re: git-gui desktop launcher

[Tobias Boesch <tobias.boesch@googlemail.com>]

On Tue, 2024-02-06 at 07:50 +0100, Johannes Sixt wrote:
> Am 05.02.24 um 21:12 schrieb Tobias Boesch:
> > Hello everyone,
> > 
> > quoting from downstream issue:
> > https://gitlab.archlinux.org/archlinux/packaging/packages/git/-/issues/5
> > 
> > -------------------------
> > 
> > "As far as I can see git gui cannot easily be used by me on arch.
> > A .desktop entry is missing for me.
> > I created one that opens git gui.
> > It also adds an entry in the "Open With..." menu of file managers
> > (I
> > tested only with Nautilus). Opeing git gui with this entry git gui
> > is
> > opened in the folder where the menu was opened.
> > If it is a git repository git gui open it. If it is no git
> > repository
> > git gui opens just as if it was called from the desktop launcher.
> > Since it took a while to create it and adds value for me I would
> > like
> > to share it to be added to the git package by default.
> > It is far from being perfect. It's a first working version. For me
> > personally it is enough.
> > Before tweaking it further to fit the packaging standards I would
> > like
> > to ask if is desired to be added.
> > 
> > .desktop file proposal
> 
> Thank you, this is certainly helpful. To get a .desktop file
> accepted,
> you would have to submit it in patch form. Additionally, since there
> is
> a dependence on the install location, it must be included in the
> build
> process.
> 

I plan to work on this. It might take some time since I cannot spend
much time on it.

> > 
> > [Desktop Entry]
> > Name=git gui
> 
> When I launch the program on my openSUSE desktop, the titlebar uses
> the
> name "Git Gui". IMO, that would make it more consistent.
> 

"Git Gui" is fine for me. I thought I took the name from the official
docs at https://git-scm.com/docs/git-gui, but there is called "git-
gui".

> > Comment=A portable graphical interface to Git
> 
> I have two gripes with this Comment:
> 
> - That the program is portable is irrelevant for the user. The word
> need
> not occur in this Comment.
> 
> - I had hoped for a more precise description. In particular, when a
> program is advertised as "graphical interface to Git", then I would
> expect that it can do a bit more than initialize repositories and
> make
> commits. At a minimum, I would expect a history viewer; but Git Gui
> doesn't have one. Unless you count the two "Visualize" entries in the
> "Repository" menu that invoke gitk as such. So, I dunno.
> 

This is the one line desciption of the official documentation.
I would like to keep this description, to be consistent with the docs.

> > Exec=/bin/bash -c 'if [[ "$0" = "/bin/bash" ]]; then git gui; else
> > cd
> > "$0" && git gui; fi' %F
> > Icon=/usr/share/git-gui/lib/git-gui.ico
> > Type=Application
> > Terminal=false
> > Categories=Development;
> > 
> > 
> > I think upstream has any interest to add this. Therefore I ask
> > here."
> > 
> > -------------------------
> > 
> > The arch package maintainer proposed to try to to add this to
> > upstream
> > before just putting it into the arch package.
> > Here I am asking if it could be added to git.
> > 
> > If it's worth to add it, I would take the time to improve it if
> > there
> > are suggestions or comments on the current version.
> > 
> > Best wishes and thanks for developing git.
> > Tobias
> 
> -- Hannes
>