From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: Jeff King <peff@peff.net>, Kevin Daudt <me@ikke.info>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] commit-template: change a message to be more intuitive
Date: Wed, 13 Sep 2017 18:01:48 +0530 [thread overview]
Message-ID: <624d873b-74af-b3e8-714c-8a439f4ee81f@gmail.com> (raw)
In-Reply-To: <20170913112013.sk7bqarq2ktrva67@sigill.intra.peff.net>
On Wednesday 13 September 2017 04:50 PM, Jeff King wrote:
> I agree with both of your points. It is very clear to me as a native
> speaker, but I can see how it might not be for everyone.
>
> Interestingly, the change here:
>
>>> - const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
>>> + const char *explanation = _("Do not edit the line above.\nEverything below will be removed.");
> actually seems less clear to me. I think of "edit" as "modify". But
> obviously it also should not be removed. Perhaps
>
> Do not modify or remove the line above.
>
> would be the most clear. Or perhaps it is overly verbose.
>
Seems to be a valid point. Further, it doesn't seem to be too verbose at
least to me. So, I'll change the
sentence and revert back to the one I use if someone finds it to be verbose.
---
Kaartic
next prev parent reply other threads:[~2017-09-13 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 10:55 [PATCH] commit-template: change a message to be more intuitive Kaartic Sivaraam
2017-09-13 10:29 ` Kevin Daudt
2017-09-13 11:20 ` Jeff King
2017-09-13 12:31 ` Kaartic Sivaraam [this message]
2017-09-13 13:05 ` [PATCH v2] " Kaartic Sivaraam
2017-09-13 12:29 ` [PATCH] " Kaartic Sivaraam
[not found] <<e656d1b4-c95e-e51d-5f48-bb3450580fa4@gmail.com>
2017-09-13 13:05 ` [PATCH v2] " Kaartic Sivaraam
2017-09-14 7:36 ` Michael J Gruber
2017-09-14 14:17 ` Kaartic Sivaraam
2017-09-14 14:41 ` Jeff King
2017-09-15 2:18 ` Junio C Hamano
2017-09-15 4:50 ` [PATCH v3] " Kaartic Sivaraam
2017-09-15 10:00 ` Michael J Gruber
2017-09-15 12:39 ` Kaartic Sivaraam
2017-09-15 1:58 ` [PATCH v2] " Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624d873b-74af-b3e8-714c-8a439f4ee81f@gmail.com \
--to=kaarticsivaraam91196@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).