From: "Josh Boyer" <jwboyer@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "David Kågedal" <davidk@lysator.liu.se>, git@vger.kernel.org
Subject: Re: [RFC] Add a suffix option to git-format-patch
Date: Wed, 17 Jan 2007 14:18:57 -0600 [thread overview]
Message-ID: <625fc13d0701171218i31585558wf89374eae9485341@mail.gmail.com> (raw)
In-Reply-To: <7vejptsglj.fsf@assigned-by-dhcp.cox.net>
On 1/17/07, Junio C Hamano <junkio@cox.net> wrote:
> David Kågedal <davidk@lysator.liu.se> writes:
>
> > "Josh Boyer" <jwboyer@gmail.com> writes:
> >
> >> I use git quite a bit to track my changes and then use
> >> git-format-patch to generate patches to send on to others. For the
> >> most part, it works great but I find myself constantly doing:
> >>
> >> mv xxxx-foo.txt xxxx-foo.patch
> >
> > Seconded. I would even prefer .patch to be default, but I guess a
> > config parameter would help me there.
>
> Two minor objections to changing the default are: (1) it's a
> change and any change is bad ;-) and (2) the reason I changed it
> to .txt before submitting the original format-patch to Linus was
> because Emacs wanted to go into its "diff" mode when files are
> named with .patch suffix, which had two annoyances (read-only by
> default, and editing patch tried to automatically recount diff
> and its recounting screwed up in some cases I do not remember
> the details about).
Well there's your problem. You're using Emacs. ;)
Seriously though, I'll try and fix up the patch a bit soon and resubmit.
josh
next prev parent reply other threads:[~2007-01-17 20:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 13:10 [RFC] Add a suffix option to git-format-patch Josh Boyer
2007-01-17 13:49 ` Johannes Schindelin
2007-01-17 14:50 ` Josh Boyer
2007-01-17 16:39 ` Horst H. von Brand
2007-01-17 19:18 ` [PATCH] Introduce 'git-format-patch --suffix=patch' Junio C Hamano
2007-01-17 19:20 ` Andy Whitcroft
2007-01-17 19:27 ` Junio C Hamano
2007-01-17 19:51 ` Brian Gernhardt
2007-01-17 19:57 ` Junio C Hamano
2007-01-17 20:08 ` Brian Gernhardt
2007-01-17 20:22 ` [PATCH] Make format-patch --suffix="" not add any suffix Brian Gernhardt
2007-01-18 1:11 ` [PATCH] Introduce 'git-format-patch --suffix=patch' Johannes Schindelin
2007-01-17 15:43 ` [RFC] Add a suffix option to git-format-patch David Kågedal
2007-01-17 16:57 ` Andreas Ericsson
2007-01-17 17:05 ` Johannes Schindelin
2007-01-17 17:33 ` Junio C Hamano
2007-01-17 18:15 ` David Kågedal
2007-01-17 20:18 ` Josh Boyer [this message]
2007-01-17 20:20 ` Josh Boyer
[not found] ` <7vsle9p8pg.fsf@assigned-by-dhcp.cox.net>
2007-01-18 0:06 ` [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt Junio C Hamano
2007-01-18 1:06 ` Johannes Schindelin
2007-01-18 7:59 ` Alex Riesen
2007-01-18 8:06 ` Shawn O. Pearce
2007-01-18 8:18 ` Alex Riesen
2007-01-18 9:10 ` Junio C Hamano
2007-01-18 9:21 ` Alex Riesen
2007-01-18 8:43 ` Junio C Hamano
2007-01-18 9:35 ` Alex Riesen
2007-01-18 11:52 ` Josh Boyer
2007-01-18 13:33 ` Johannes Schindelin
2007-01-18 13:46 ` Alex Riesen
2007-01-18 13:40 ` Alex Riesen
2007-01-18 14:10 ` Andreas Ericsson
2007-01-18 14:15 ` Johannes Schindelin
2007-01-18 14:41 ` Alex Riesen
2007-01-18 14:49 ` Johannes Schindelin
2007-01-18 14:53 ` Alex Riesen
2007-01-18 15:16 ` Johannes Schindelin
2007-01-18 15:37 ` Alex Riesen
2007-01-18 15:42 ` Josh Boyer
2007-01-18 20:03 ` Johannes Schindelin
2007-01-18 20:12 ` Josh Boyer
2007-01-18 15:26 ` Shawn O. Pearce
2007-01-18 15:52 ` Alex Riesen
2007-01-18 19:29 ` Steven Grimm
2007-01-18 19:57 ` Johannes Schindelin
2007-01-18 16:09 ` Johannes Sixt
2007-01-19 10:11 ` Jakub Narebski
2007-01-18 15:42 ` Shawn O. Pearce
2007-01-18 16:05 ` Alex Riesen
2007-01-18 16:29 ` Andreas Ericsson
2007-01-18 16:51 ` Shawn O. Pearce
2007-01-18 17:03 ` Andreas Ericsson
2007-01-18 19:30 ` Martin Langhoff
2007-01-18 19:19 ` Martin Langhoff
2007-01-18 12:40 ` Andreas Ericsson
2007-01-18 15:10 ` Lukas Sandström
2007-01-18 15:29 ` Brian Gernhardt
2007-01-18 9:57 ` Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=625fc13d0701171218i31585558wf89374eae9485341@mail.gmail.com \
--to=jwboyer@gmail.com \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).