From: Lars Schneider <larsxschneider@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
David Turner <dturner@twosigma.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values
Date: Tue, 11 Apr 2017 13:44:19 +0200 [thread overview]
Message-ID: <62969B9F-F79E-4CBA-A343-BC8D9CDBADB6@gmail.com> (raw)
In-Reply-To: <3d351f90-af4f-1ddb-c8a0-3e7926fd722d@ramsayjones.plus.com>
> On 04 Apr 2017, at 17:20, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>
>
> On 04/04/17 00:53, David Turner wrote:
>> Unfortunately, in order to push some large repos, the http postbuffer
>> must sometimes exceed two gigabytes. On a 64-bit system, this is OK:
>> we just malloc a larger buffer.
>>
>> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the
>> buffer size.
>>
>> Signed-off-by: David Turner <dturner@twosigma.com>
>> ---
>>
>> V5 addresses comments from Torsten Boegershausen and Ramsay Jones. Since
>> I don't have a 32-bit machine handy, it's difficult for me to check
>> for compiler warnings on 32-bit machines. Hopefully my guess as
>> to the solution to Ramsay's issue will be correct.
>
> Yep, this compiles without complaint.
Hi David,
You can test the 32-bit build on your machine by ...
1. Pulling this Docker image:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L58
2. Starting the Docker image:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L72
3. Running the linux32 build:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L73
Cheers,
Lars
prev parent reply other threads:[~2017-04-11 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 23:53 [PATCH v5] http.postbuffer: allow full range of ssize_t values David Turner
2017-04-04 1:32 ` Jonathan Nieder
2017-04-04 2:33 ` Jeff King
2017-04-04 15:20 ` Ramsay Jones
2017-04-11 11:44 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62969B9F-F79E-4CBA-A343-BC8D9CDBADB6@gmail.com \
--to=larsxschneider@gmail.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).