From: Michael Lukashov <michael.lukashov@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll
Date: Thu, 28 Jan 2010 13:18:56 +0300 [thread overview]
Message-ID: <63cde7731001280218g29a63094od4f5a8135c6986a4@mail.gmail.com> (raw)
In-Reply-To: <4B61543F.6020904@viscovery.net>
> Thanks. Due to the size of the change, I would acknowledge it only if you
> have a proof that the reduced startup costs are noticable, for example, by
> running the test suite.
>
> What's the deal with bswap? Isn't it an unrelated change? It needs some
> better justification. It is unobvious because it is not straight-forward
> "use pointer to function that was looked up instead of function".
>
> Will the result not break the MSVC build?
>
> -- Hannes
>
"git status" calls ntohs function, which was loaded from ws2_32.dll
I've noticed that bswap.h contains implementation of ntohl htonl functions,
so I decided to add implementation of ntohs htons functions, which is
pretty trivial.
After that call to "git status" doesn't load ws2_32.dll
next prev parent reply other threads:[~2010-01-28 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 8:15 [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll Michael Lukashov
2010-01-28 9:09 ` Johannes Sixt
2010-01-28 10:18 ` Michael Lukashov [this message]
2010-01-28 10:38 ` Johannes Schindelin
2010-01-28 10:47 ` Michael Lukashov
2010-01-29 7:44 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63cde7731001280218g29a63094od4f5a8135c6986a4@mail.gmail.com \
--to=michael.lukashov@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).