From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] doc: set actual revdate for manpages
Date: Fri, 14 Apr 2023 12:40:40 -0600 [thread overview]
Message-ID: <64399e28eed60_5f7732949f@chronos.notmuch> (raw)
In-Reply-To: <xmqqa5zas7xf.fsf@gitster.g>
Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Formatted output from a repository working tree changes from
> > "04/14/2023" to "2023-04-13". The value change may be intended,...
>
> Forgot to mention another thing. While it may be a good idea to tie
> the datestamp etched in the formatted result to that of the source
> material, rather than the date the formatter happened to have been
> run, the committer date is more appropriate than the author date for
> that purpose, as the former is the date that the change made on the
> latter date (which is earlier) has become a part of the whole, from
> which the formatted result was produced.
>
> It may not make a big practical difference:
Or _any_ practical difference.
> * For an individual who is trying out the changes just made, the
> committer time and the author time are likely identical.
>
> * For a release process, what is at the tip of the released branch
> is likely be the release notes and version bump, recorded by the
> releaser, and again the committer time and the author time are
> likely identical.
>
> * For results of a pull request, the times are likely identical for
> the merge commit.
Agreed that committer == author in these cases.
> but from the philosophical standpoint, it does matter.
I prefer to focus on the real rather than hypothetical (or
philosophical).
I do create my own releases (e.g. 2.40.0+fc1) and a real issue with the
version script (rather than philosphical) is that it only considers
annotated tags, so I have to carry a patch that adds `--tags` to the
`git describe` command.
Shouldn't dealing with real issues of real people have a higher priority
than philosophical issues?
For the record, I do agree the committer date feels more proper, but it
doesn't make any real difference, I just wonder about the priorities.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2023-04-14 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 7:47 [PATCH] doc: set actual revdate for manpages Felipe Contreras
2023-04-14 7:04 ` Jeff King
2023-04-14 12:40 ` Felipe Contreras
2023-04-14 16:46 ` Junio C Hamano
2023-04-14 17:14 ` Junio C Hamano
2023-04-14 18:40 ` Felipe Contreras [this message]
2023-04-14 18:26 ` Felipe Contreras
2023-04-14 21:45 ` Jeff King
2023-04-14 22:06 ` Junio C Hamano
2023-04-14 21:35 ` Jeff King
2023-04-14 15:27 ` Junio C Hamano
2023-04-14 16:20 ` Felipe Contreras
2023-04-14 17:36 ` Junio C Hamano
2023-04-14 18:59 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64399e28eed60_5f7732949f@chronos.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox