From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Samuel Ferencik <sferencik@gmail.com>
Cc: "Philip Oakley" <philipoakley@iee.email>,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2] config: introduce an Operating System-specific `includeIf` condition
Date: Mon, 17 Apr 2023 20:04:01 -0600 [thread overview]
Message-ID: <643dfa919c8e1_19bb029491@chronos.notmuch> (raw)
In-Reply-To: <xmqq7cuamjmu.fsf@gitster.g>
Junio C Hamano wrote:
> Samuel Ferencik <sferencik@gmail.com> writes:
>
> >>>> Let's introduce a new condition: `os:<uname-s>` where `<uname-s>` is the
> >>>> system name, i.e. the output of `uname -s`.
> >
> > The discussion about https://github.com/gitgitgadget/git/pull/1429 seems to
> > have stalled on several points. I'll try to summarise; let's see if we can move
> > forward.
> >
> > (I am the reporter of https://github.com/git-for-windows/git/issues/4125, which
> > led to this PR. I am vested in making progress here.)
> >
> > 1. name of the setting (`os` vs `uname-s` vs `sysname`)
>
> I do not think it is a good idea to squat on too generic a name like
> 'os', especially when there are multiple layers people will care
> about. But I think the original thread discussed this to death, and
> I do not see a point bringing it up again as the first bullet point.
"platform" is the term I've seen to be less OS-centric.
--
Felipe Contreras
next prev parent reply other threads:[~2023-04-18 2:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:39 [PATCH] config: introduce an Operating System-specific `includeIf` condition Johannes Schindelin via GitGitGadget
2022-11-21 13:51 ` Ævar Arnfjörð Bjarmason
2022-11-21 15:51 ` Phillip Wood
2022-11-21 19:18 ` Johannes Schindelin
2022-11-21 19:19 ` [PATCH v2] " Johannes Schindelin via GitGitGadget
2022-11-21 23:32 ` Jeff King
2022-11-23 11:54 ` Đoàn Trần Công Danh
2022-11-24 0:56 ` Jeff King
2022-11-22 14:01 ` Ævar Arnfjörð Bjarmason
2022-11-22 14:31 ` Phillip Wood
2022-11-23 0:16 ` Junio C Hamano
2022-11-23 15:07 ` Phillip Wood
2022-11-23 23:51 ` Junio C Hamano
2022-11-22 18:40 ` Philippe Blain
2022-11-23 10:40 ` Philip Oakley
2022-11-25 7:31 ` Junio C Hamano
2023-04-17 7:04 ` Samuel Ferencik
2023-04-17 18:46 ` Junio C Hamano
2023-04-18 2:04 ` Felipe Contreras [this message]
2023-04-19 12:22 ` Johannes Schindelin
2023-04-19 14:26 ` Chris Torek
2023-04-19 14:32 ` Samuel Ferencik
2023-04-19 15:21 ` rsbecker
2023-04-19 16:07 ` Junio C Hamano
2023-04-19 16:14 ` Junio C Hamano
2022-11-22 0:03 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643dfa919c8e1_19bb029491@chronos.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=philipoakley@iee.email \
--cc=phillip.wood123@gmail.com \
--cc=sferencik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).