git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Thomas Braun <thomas.braun@virtuell-zuhause.de>,
	Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>,
	GIT Mailing-list <git@vger.kernel.org>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: 2.29.0.rc0.windows.1: Duplicate commit id error message when fetching
Date: Fri, 9 Oct 2020 13:46:07 -0400	[thread overview]
Message-ID: <64de22fd-2e1b-aaab-3a8e-f6f1d630a46e@gmail.com> (raw)
In-Reply-To: <2f30099a-4a3d-00f7-bb08-ca6c1f76bcd4@virtuell-zuhause.de>

On 10/9/2020 1:12 PM, Thomas Braun wrote:
> Sure! Please find them attached. I retried with no jobs parameter as
> well, same issues.
> 
> I did some more bisecting of my git settings. And now it's getting
> embarrassing...
> 
> Can you reproduce it if you do
> 
> git config core.commitGraph false
> git config fetch.writeCommitGraph true
> ?

I _can_ repro it in this case! I think there must be something
very interesting going on where the commit-graph is parsed in
_some_ places, but not in others. This is something that I can
really start to dig into.

It's important to note that the final "git fetch" adds a layer
to the commit-graph chain even though we shouldn't be reading
from the commit-graph file! This is an unusual situation that
is unexpected, but should be handled correctly.

My gut reaction is to end early in any commit-graph write
method when core.commitGraph is false. But that only papers
over the real issue here. I'll keep digging.

Thanks for the logs, they may come in handy!
-Stolee


  reply	other threads:[~2020-10-09 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 20:28 2.29.0.rc0.windows.1: Duplicate commit id error message when fetching Thomas Braun
2020-10-07 21:06 ` Jeff King
2020-10-08  9:52   ` Thomas Braun
2020-10-08 12:06     ` Jeff King
2020-10-08 12:50       ` Derrick Stolee
2020-10-08 13:22         ` Derrick Stolee
2020-10-09 15:29           ` Thomas Braun
2020-10-09 16:49             ` Derrick Stolee
2020-10-09 17:12               ` Thomas Braun
2020-10-09 17:46                 ` Derrick Stolee [this message]
2020-10-09 17:55                   ` Jeff King
2020-10-09 18:28                     ` Taylor Blau
2020-10-09 18:33                       ` Derrick Stolee
2020-10-09 18:37                         ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64de22fd-2e1b-aaab-3a8e-f6f1d630a46e@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=thomas.braun@virtuell-zuhause.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).