git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Gustavsson" <bgustavsson@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Teach 'rebase -i' the command "amend"
Date: Mon, 5 Oct 2009 08:08:49 +0200	[thread overview]
Message-ID: <6672d0160910042308v7280dcadyff97b977bcfe12c3@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0910042308200.4985@pacific.mpi-cbg.de>

2009/10/4 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> I thought that we had a discussion about this and that the consensus was
> that "amend" would be misleading.  Maybe you can find that thread in
> GMane?

I found this thread from January 2009:

http://thread.gmane.org/gmane.comp.version-control.git/105738

Having read the thread, I agree that "amend" would be misleading.

There were several suggestions for alternate command names
in that thread, for example:

"msg", "msgedit", "message", "reword", "rephrase"

It think that "msgedit" was suggested by several people. ("editmsg"
was also suggested, but it is not possible as the abbreviation "e" would
become ambiguous.)

Would the patch have a chance to be accepted if I renamed
the new command to "msgedit"?

/Björn

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB

  reply	other threads:[~2009-10-05  6:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-04 19:06 [PATCH] Teach 'rebase -i' the command "amend" Björn Gustavsson
2009-10-04 21:09 ` Johannes Schindelin
2009-10-05  6:08   ` Björn Gustavsson [this message]
2009-10-05  6:33     ` Junio C Hamano
2009-10-05  9:17     ` Johannes Schindelin
2009-10-05  9:39       ` Sverre Rabbelier
2009-10-05 16:10         ` Björn Gustavsson
2009-10-05 19:43           ` Anders Melchiorsen
2009-10-05 20:50             ` Johannes Schindelin
2009-10-05 21:07               ` Junio C Hamano
2009-10-05 21:13                 ` Sverre Rabbelier
2009-10-05 21:26                 ` Johannes Schindelin
2009-10-06  5:53                   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6672d0160910042308v7280dcadyff97b977bcfe12c3@mail.gmail.com \
    --to=bgustavsson@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).