From: "Björn Gustavsson" <bgustavsson@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rebase -i: print the editor name if it fails to launch
Date: Mon, 21 Dec 2009 08:54:05 +0100 [thread overview]
Message-ID: <6672d0160912202354m124700dbw6e2089446d88b24@mail.gmail.com> (raw)
In-Reply-To: <7v4onlbi3q.fsf@alter.siamese.dyndns.org>
2009/12/20 Junio C Hamano <gitster@pobox.com>:
> Isn't this too elaborate? git_editor() has already run and when it
> attempted to launch the editor it assigned to GIT_EDITOR in order to use
> it as an eval string.
I wanted to hide the details about the inner working of git_editor(),
but since it is only called in one place, yes, it is too elaborate.
>
> git_editor "$TODO" ||
> die_abort "Failed to run '${GIT_EDITOR:-your editor}'"
>
> would suffice, no?
Yes. Much better. I will rewrite my patch when I'll get home from
work later today.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
prev parent reply other threads:[~2009-12-21 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 8:32 [PATCH] rebase -i: print the editor name if it fails to launch Björn Gustavsson
2009-12-20 8:40 ` Björn Gustavsson
2009-12-20 18:44 ` Junio C Hamano
2009-12-21 7:54 ` Björn Gustavsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6672d0160912202354m124700dbw6e2089446d88b24@mail.gmail.com \
--to=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).