git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Gustavsson" <bgustavsson@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add a test for a problem in "rebase --whitespace=fix"
Date: Wed, 10 Feb 2010 21:20:18 +0100	[thread overview]
Message-ID: <6672d0161002101220h34ebbda8o3fde503d41c8313e@mail.gmail.com> (raw)
In-Reply-To: <7vzl3i137f.fsf@alter.siamese.dyndns.org>

2010/2/9 Junio C Hamano <gitster@pobox.com>:
> I actually changed my mind after thinking about it a bit more.

Thanks for thinking more about it and for your explanation
about the algorithm

I am quite busy at the moment, but I hope to get started
on a patch series after the end of February.

> I'd like to see this logic (and only this logic, without relying on the
> diff hunk offset numbers at all) done first, because it is very much in
> line with what we already do, and more importantly, because it is a more
> general solution that is applicable outside the context of rebase.

I'll try to implement that logic. It seems that it should cover
99% of all real-world use cases. I will not worry about the general
case (tons of blanks) until I have got the first patch working.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB

      reply	other threads:[~2010-02-10 20:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07  8:10 [PATCH] Add a test for a problem in "rebase --whitespace=fix" Björn Gustavsson
2010-02-07 18:38 ` Junio C Hamano
2010-02-07 22:44   ` Björn Gustavsson
2010-02-08  0:15     ` Junio C Hamano
2010-02-08  7:37       ` Björn Gustavsson
2010-02-09 21:58         ` Junio C Hamano
2010-02-10 20:20           ` Björn Gustavsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6672d0161002101220h34ebbda8o3fde503d41c8313e@mail.gmail.com \
    --to=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).