From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5E8262022A for ; Thu, 27 Oct 2016 06:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754888AbcJ0GK2 (ORCPT ); Thu, 27 Oct 2016 02:10:28 -0400 Received: from bsmtp.bon.at ([213.33.87.14]:33500 "EHLO bsmtp.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873AbcJ0GK2 (ORCPT ); Thu, 27 Oct 2016 02:10:28 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp.bon.at (Postfix) with ESMTPSA id 3t4Ghd3tW7z5tlc; Thu, 27 Oct 2016 08:10:25 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id AC1C8124; Thu, 27 Oct 2016 08:10:24 +0200 (CEST) Subject: Re: [PATCH] compat: Allow static initializer for pthreads on Windows To: Junio C Hamano References: <20161026215732.16411-1-sbeller@google.com> <93be5d21-6cb6-ee2b-9f4f-c2fe7c690d6c@kdbg.org> Cc: Stefan Beller , Johannes.Schindelin@gmx.de, git@vger.kernel.org, simon@ruderich.org, peff@peff.net From: Johannes Sixt Message-ID: <67e38b43-0264-12f2-cca8-4b718ed7dc9d@kdbg.org> Date: Thu, 27 Oct 2016 08:10:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 27.10.2016 um 08:02 schrieb Junio C Hamano: > Johannes Sixt writes: > >> Am 26.10.2016 um 23:57 schrieb Stefan Beller: >>> In Windows it is not possible to have a static initialized mutex as of >>> now, but that seems to be painful for the upcoming refactoring of the >>> attribute subsystem, as we have no good place to put the initialization >>> of the attr global lock. >> >> Please rewrite the attribute system such that it can have a dynamic >> initialization. If you find a global initialization in main() too >> gross (I would agree) then setup_git_directory() might be the right >> place. > > As many codepaths may not even need access to the attributes, I > doubt that would be a very productive direction to go. So, what is productive then? Pessimizing one (not exactly minor) platform? -- Hannes