From: "Don Zickus" <dzickus@gmail.com>
To: "Marcus Griep" <neoeinstein@gmail.com>
Cc: "Marco Costalba" <mcostalba@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"git mailing list" <git@vger.kernel.org>
Subject: Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"
Date: Wed, 20 Aug 2008 09:10:11 -0400 [thread overview]
Message-ID: <68948ca0808200610v6d81228fiabf0317ee4ae6ec5@mail.gmail.com> (raw)
In-Reply-To: <48AB0983.2050706@gmail.com>
On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote:
> Marcus Griep wrote:
>> It looks like an empty line added to the end of the file.
>> Unsanitary, but ok since it comes after the last MIME
>> multipart boundary. Junio could probably just ax the change
>> to sample.mbox from the patch before applying it.
No the change was intentional. In fact, because that extra line was
not there, a bug was hidden. Adding the extra line exposed the bug
and hopefully will catch any more bugs in the future with regards to
the boundary code.
>
> Or I could have misunderstood the intent of the change, and it
> is necessary to fully test the change, since it appears to
> operate line-by-line, an empty line at the end would be necessary
> to trigger the code path that stops mailinfo from looking for
> another boundary.
Yes, exactly.
Cheers,
Don
prev parent reply other threads:[~2008-08-20 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:38 Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" Marco Costalba
2008-08-19 17:51 ` Marcus Griep
2008-08-19 17:57 ` Marcus Griep
2008-08-20 13:10 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68948ca0808200610v6d81228fiabf0317ee4ae6ec5@mail.gmail.com \
--to=dzickus@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
--cc=neoeinstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).