Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

[Marco Costalba]

Looking the diff at

http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a

the part of the patch applied to /t/t5100/sample.mbox file seems very
strange, is it correct ?

Marco

Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

[Marcus Griep]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Marco Costalba wrote:
> Looking the diff at
> 
> http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a
> 
> the part of the patch applied to /t/t5100/sample.mbox file seems very
> strange, is it correct ?

It looks like an empty line added to the end of the file.
Unsanitary, but ok since it comes after the last MIME
multipart boundary.  Junio could probably just ax the change
to sample.mbox from the patch before applying it.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

[Marcus Griep]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Marcus Griep wrote:
> It looks like an empty line added to the end of the file.
> Unsanitary, but ok since it comes after the last MIME
> multipart boundary.  Junio could probably just ax the change
> to sample.mbox from the patch before applying it.

Or I could have misunderstood the intent of the change, and it
is necessary to fully test the change, since it appears to
operate line-by-line, an empty line at the end would be necessary
to trigger the code path that stops mailinfo from looking for
another boundary.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

[Don Zickus]

On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote:
> Marcus Griep wrote:
>> It looks like an empty line added to the end of the file.
>> Unsanitary, but ok since it comes after the last MIME
>> multipart boundary.  Junio could probably just ax the change
>> to sample.mbox from the patch before applying it.

No the change was intentional.  In fact, because that extra line was
not there, a bug was hidden.  Adding the extra line exposed the bug
and hopefully will catch any more bugs in the future with regards to
the boundary code.

>
> Or I could have misunderstood the intent of the change, and it
> is necessary to fully test the change, since it appears to
> operate line-by-line, an empty line at the end would be necessary
> to trigger the code path that stops mailinfo from looking for
> another boundary.

Yes, exactly.

Cheers,
Don