From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA3AC48BE5 for ; Tue, 15 Jun 2021 23:28:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4425461245 for ; Tue, 15 Jun 2021 23:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbhFOXao (ORCPT ); Tue, 15 Jun 2021 19:30:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231476AbhFOXao (ORCPT ); Tue, 15 Jun 2021 19:30:44 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD4F5C061574 for ; Tue, 15 Jun 2021 16:28:37 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id he7so454026ejc.13 for ; Tue, 15 Jun 2021 16:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4ObfBXp7J45EgVR7k9K9u6csc/VdGrFYdE6rSPanz4Q=; b=D3i4zWgKNk8PRDIttELuo1/UgJ5Su277QmQNvN2LyizbQENu+lCi641wJYdx62o2Te 7MgPYNJOIYMQZRLI6YbHVeNHyh7p4t+HGFfxbnBO2dpe5e01B9/Qk35HhsdTwzIHM/vY ENm6RWdZbMP1XHAgmMWG+cQXezLb95/nrPwS6e6Qr48eHhWtCKhvBA8uoenHsx0GNv9o XRbpOBnj3imOACqXSOolp8+AYfnH0Ji2bjXHYBeU+t6uAINdKG8Xz4pKazyqAFXrfhiL tWQqps3HQ6Osx3mX1OhYuikqPxaUxiU8sGLB0BgEIH14d7I0BVuPXlP0vLR2N8doqfL+ biWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4ObfBXp7J45EgVR7k9K9u6csc/VdGrFYdE6rSPanz4Q=; b=M45vV4CmMfDRwm7jV8ZjafwGTp3CJz7V7QsuKOwRpoDsSs+I5rVAadjUDjoSSff1Xe y7NvgH0r7UGWrpTpzRp9P4/LEvP1fd8ULt6PuLQhH6ZPZk22w4I6HVhI9fpKP0wUgMME 6vofeI71/fiyrMIfaXyXX4Cu6zWpls/k9YfFxwI1343NQgKenfJphW6gCkKh9k8OkZ5k io6Kp0W9jth0xvGCuZVR0DYcDmb6E6LE/qRg6nE0jsmaYlR8H614ExLw3gUdINwnf05W RwyXJnXXq0H0z+c+8P70vZtEUGdhi67fLqRuAwSeWQGR3iccRh/05pTZJeuAnydSWtb6 utRA== X-Gm-Message-State: AOAM530tikwPdcHHvm34vxukTaC8YFQ6Lqs9bme0ZlCtDJSlzYl2DWMm WRNGCHXQFRNylmmfQ9+Bhz1p/vR/7wL7KnlYk9o= X-Google-Smtp-Source: ABdhPJztRsgryfcdGFBl3ctLt1CNghb34F64DXBhSvHBLXRj68pQqmL1EviAInycDwmtQeEEHJk9mg== X-Received: by 2002:a17:907:3e04:: with SMTP id hp4mr2004549ejc.473.1623799716208; Tue, 15 Jun 2021 16:28:36 -0700 (PDT) Received: from [10.19.18.14] ([212.102.57.84]) by smtp.gmail.com with ESMTPSA id bx17sm84965ejc.94.2021.06.15.16.28.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jun 2021 16:28:35 -0700 (PDT) Subject: [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master) From: Andrei Rybak To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: git@vger.kernel.org References: <1d003cac-83fa-0b63-f60e-55513ac45cf9@gmail.com> Message-ID: <6980e906-8076-1436-ecdb-6775eff55d39@gmail.com> Date: Wed, 16 Jun 2021 01:28:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1d003cac-83fa-0b63-f60e-55513ac45cf9@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 15/06/2021 22:55, Andrei Rybak wrote: > Hi, > > I've taken an example of how to use GIT_SKIP_TESTS directly from > t/README: > >     $ GIT_SKIP_TESTS='t[0-4]??? t91?? t9200.8' make > > and noticed that t0000 is still being run.  I've written a script to > bisect the issue: > > >     #/bin/sh > >     ( >             cd t >             GIT_SKIP_TESTS='t[0-4]??? t91?? t9200.8' make | \ >                     head | grep 'SKIP skip all tests in t0000' >     ) > > > and it bisected to edc23840b0 (test-lib: bring $remove_trash out of > retirement, 2021-05-10) which was merged to master in 2019256717 ("Merge > branch 'ab/test-lib-updates'", 2021-06-14). > > Note, that spelling out the tests number in full works, i.e. > >     $ GIT_SKIP_TESTS=t0000 make > > won't run t0000. I sent this originally with incorrect subject. Question marks, e.g. $ GIT_SKIP_TESTS='t000?' make work. It is the range expressions, like [0-9] that are broken: $ GIT_SKIP_TESTS='t[0-9]000' make