From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Isoken June Ibizugbe <isokenjune@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines
Date: Sat, 21 Oct 2023 12:31:21 +0200 [thread overview]
Message-ID: <6996af48-4998-4370-813a-6c72a9ffb1b4@gmail.com> (raw)
In-Reply-To: <xmqqwmvhqjyx.fsf@gitster.g>
On 20-oct-2023 10:31:18, Junio C Hamano wrote:
> Rubén Justo <rjusto@gmail.com> writes:
>
> > On 19-oct-2023 09:40:51, Isoken June Ibizugbe wrote:
> >
> >> As per the CodingGuidelines document, it is recommended that a single-line
> >> message provided to error messages such as die(), error() and warning(),
> >
> > This is confusing; some multi-line messages are fixed in this series.
What I expected to see is a re-roll with no mention about
single/multi-line.
> >> should start with a lowercase letter and should not end with a period.
> >> Also this patch fixes the tests broken by the changes.
>
> "Also this patch fixes the tests broken by the changes" -> "Adjust
> tests to match updated messages".
That is a more palatable description of why the tests are being touched
in this series. Thanks.
next prev parent reply other threads:[~2023-10-21 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:12 [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe
2023-10-18 18:19 ` Rubén Justo
2023-10-18 18:44 ` Junio C Hamano
2023-10-19 8:40 ` [PATCH v2] builtin/branch.c: " Isoken June Ibizugbe
2023-10-19 19:20 ` Rubén Justo
2023-10-20 17:31 ` Junio C Hamano
2023-10-20 17:59 ` Isoken Ibizugbe
2023-10-21 10:31 ` Rubén Justo [this message]
2023-10-21 10:27 ` Rubén Justo
2023-10-20 4:26 ` Isoken Ibizugbe
2023-10-20 9:41 ` Christian Couder
2023-10-20 17:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6996af48-4998-4370-813a-6c72a9ffb1b4@gmail.com \
--to=rjusto@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=isokenjune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).